Skip to content

Commit

Permalink
aot_compile_op_call: Stop setting calling convention explicitly (#3140)
Browse files Browse the repository at this point in the history
The current logic doesn't work for some cases.
cf. #3138

It's unclear why we are setting the calling convention explicitly here
at all. In many cases, the default just seems working.
  • Loading branch information
yamt authored Feb 6, 2024
1 parent cfa90ca commit 6e547ba
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions core/iwasm/compilation/aot_emit_function.c
Original file line number Diff line number Diff line change
Expand Up @@ -1088,10 +1088,6 @@ aot_compile_op_call(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx,
goto fail;
}

/* Set calling convention for the call with the func's calling
convention */
LLVMSetInstructionCallConv(value_ret, LLVMGetFunctionCallConv(func));

if (tail_call)
LLVMSetTailCall(value_ret, true);

Expand Down

0 comments on commit 6e547ba

Please sign in to comment.