Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aot_compile_op_call: stop setting calling convention explicitly #3140

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Feb 6, 2024

The current logic doesn't work for some cases.
cf. #3138

It's unclear why we are setting the calling convention explicitly here at all. In many cases, the default just seems working.

The current logic doesn't work for some cases.
cf. bytecodealliance#3138

It's unclear why we are setting the calling convention explicitly here
at all. In many cases, the default just seems working.
@yamt
Copy link
Collaborator Author

yamt commented Feb 6, 2024

the ci failure looks like #2776

    (import "not wasm" "overloaded" (global i64))
    (import "not wasm" "overloaded" (global f32))
    (import "not wasm" "overloaded" (global f64))
    (import "not wasm" "overloaded" (table 0 funcref))
    (import "not wasm" "overloaded" (memory 0))
  )'
exception is ....'unknown import'
Writing WAST module to 'C:\Users\RUNNER~1\AppData\Local\Temp\tmplthf_pwl.wast'
Compiling WASM to 'C:\Users\RUNNER~1\AppData\Local\Temp\tmp2ye2ialk.wasm'
Running: ./wabt/out/gcc/Release/wat2wasm.exe --enable-thread --no-check C:\Users\RUNNER~1\AppData\Local\Temp\tmplthf_pwl.wast -o C:\Users\RUNNER~1\AppData\Local\Temp\tmp2ye2ialk.wasm
Starting interpreter for module 'C:\Users\RUNNER~1\AppData\Local\Temp\tmp2ye2ialk.wasm'
Running: ../../../product-mini/platforms/windows/build/RelWithDebInfo/iwasm.exe --module-path=C:\Users\RUNNER~1\AppData\Local\Temp --heap-size=0 -v=0 --repl C:\Users\RUNNER~1\AppData\Local\Temp\tmp2ye2ialk.wasm
Removing tempfiles
failed with a non-zero return code 1

spec tests FAILED
Error: Process completed with exit code 1

@wenyongh wenyongh merged commit 6e547ba into bytecodealliance:main Feb 6, 2024
395 checks passed
wenyongh added a commit that referenced this pull request Feb 17, 2024
Apply patches in branch main for branch `release/1.3.x`:
- Fix loader check_wasi_abi_compatibility (#3126)
- Zero the memory mapped from os_mmap in NuttX (#3132)
- Fix possible integer overflow in loader target block check (#3133)
- Fix locel.set in polymorphic stack (#3135)
- Fix threads opcodes' boundary check in classic-interp and fast-interp (#3136)
- aot_compile_op_call: Stop setting calling convention explicitly (#3140)
- aot compiler: Place precheck wrapper before the corresponding wrapped function (#3141)
- fast-interp: Fix copy_stack_top_i64 overlap issue (#3146)
- fast-interp: Fix frame_offset overflow issue (#3149)
- Fix null pointer access in fast-interp when configurable soft bound check is enabled (#3150)
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…codealliance#3140)

The current logic doesn't work for some cases.
cf. bytecodealliance#3138

It's unclear why we are setting the calling convention explicitly here
at all. In many cases, the default just seems working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants