Fix null pointer access in fast interpreter mode when configurable software bound check is enabled #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Feb 7, 2024
…ftware bound check is enabled The wasm_interp_call_func_bytecode is called for the first time with the empty module / exec_env to generate a global_handle_table. Before that happens though, the function checks if the module instance has bounds check enabled. Because the module instance is null, the program crashes. I added an extra check to prevent the crashes.
wenyongh
approved these changes
Feb 14, 2024
wenyongh
added a commit
that referenced
this pull request
Feb 17, 2024
Apply patches in branch main for branch `release/1.3.x`: - Fix loader check_wasi_abi_compatibility (#3126) - Zero the memory mapped from os_mmap in NuttX (#3132) - Fix possible integer overflow in loader target block check (#3133) - Fix locel.set in polymorphic stack (#3135) - Fix threads opcodes' boundary check in classic-interp and fast-interp (#3136) - aot_compile_op_call: Stop setting calling convention explicitly (#3140) - aot compiler: Place precheck wrapper before the corresponding wrapped function (#3141) - fast-interp: Fix copy_stack_top_i64 overlap issue (#3146) - fast-interp: Fix frame_offset overflow issue (#3149) - Fix null pointer access in fast-interp when configurable soft bound check is enabled (#3150)
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…heck is enabled (bytecodealliance#3150) The wasm_interp_call_func_bytecode is called for the first time with the empty module/exec_env to generate a global_handle_table. Before that happens though, the function checks if the module instance has bounds check enabled. Because the module instance is null, the program crashes. This PR added an extra check to prevent the crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm_interp_call_func_bytecode is called for the first time with the empty module / exec_env to generate a global_handle_table. Before that happens though, the function checks if the module instance has bounds check enabled. Because the module instance is null, the program crashes. I added an extra check to prevent the crashes.