Require the gc proposal with usage of (rec ...)
#1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI is failing due to #1178, nothing major though |
pchickey
approved these changes
Aug 25, 2023
This commit is a follow-up to bytecodealliance#1134 to require the `gc` feature flag be activated to use the `(rec ...)` construct from the GC wasm proposal. This additionally updates the text parsing and text printing to consider the structure of what's parsed for encoding/printing rather than the size of the types inside. Even a `rec` group of a single type prints a `rec` group or encodes it now instead of silently switching it back to a single-type encoding.
alexcrichton
force-pushed
the
gate-more-gc-features
branch
from
6c5c023 to
9f1c8f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow-up to #1134 to require the
gcfeature flag be activated to use the(rec ...)construct from the GC wasm proposal. This additionally updates the text parsing and text printing to consider the structure of what's parsed for encoding/printing rather than the size of the types inside. Even arecgroup of a single type prints arecgroup or encodes it now instead of silently switching it back to a single-type encoding.