Skip to content

Commit

Permalink
Temporarily remove support for interface types (#1292)
Browse files Browse the repository at this point in the history
* Temporarily remove support for interface types

This commit temporarily removes support for interface types from the
`wasmtime` CLI and removes the `wasmtime-interface-types` crate. An
error is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:

* #677 - tracking work for re-adding interface types support
* #1271 - rationale for removal and links to other discussions

Closes #1271

* Update the python extension
  • Loading branch information
alexcrichton authored Mar 12, 2020
1 parent 6e55c54 commit 34f768d
Show file tree
Hide file tree
Showing 20 changed files with 113 additions and 734 deletions.
18 changes: 0 additions & 18 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ doc = false
wasmtime = { path = "crates/api" }
wasmtime-debug = { path = "crates/debug" }
wasmtime-environ = { path = "crates/environ" }
wasmtime-interface-types = { path = "crates/interface-types" }
wasmtime-jit = { path = "crates/jit" }
wasmtime-obj = { path = "crates/obj" }
wasmtime-profiling = { path = "crates/profiling" }
Expand Down
22 changes: 22 additions & 0 deletions crates/api/src/module.rs
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,28 @@ impl Module {
}
}
}
SectionCode::Custom {
name: "webidl-bindings",
..
}
| SectionCode::Custom {
name: "wasm-interface-types",
..
} => {
bail!(
"\
support for interface types has temporarily been removed from `wasmtime`
for more information about this temoprary you can read on the issue online:
https://github.com/bytecodealliance/wasmtime/issues/1271
and for re-adding support for interface types you can see this issue:
https://github.com/bytecodealliance/wasmtime/issues/677
"
);
}
_ => {
// skip other sections
}
Expand Down
25 changes: 0 additions & 25 deletions crates/interface-types/Cargo.toml

This file was deleted.

4 changes: 0 additions & 4 deletions crates/interface-types/README.md

This file was deleted.

Loading

0 comments on commit 34f768d

Please sign in to comment.