Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove current outdated implementation of interface types #1271

Closed
alexcrichton opened this issue Mar 10, 2020 · 0 comments · Fixed by #1292
Closed

Remove current outdated implementation of interface types #1271

alexcrichton opened this issue Mar 10, 2020 · 0 comments · Fixed by #1292
Labels
wasmtime Issues about wasmtime that don't fall into another label

Comments

@alexcrichton
Copy link
Member

There's been a small amount of discussion on Zulip about what to do about interface types. I'd like to move that discussion here and formally propose that we take @tschneidereit's idea and do the following:

  • Remove all support in wasmtime for interface types
  • Parse known interface types section names and warn/error that support is not available at this time
  • Link to Support for Interface Types in wasmtime API #677 for discussion about progress towards implementing interface types in wasmtime
@alexcrichton alexcrichton added the wasmtime Issues about wasmtime that don't fall into another label label Mar 10, 2020
@silvanshade silvanshade mentioned this issue Mar 10, 2020
Closed
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Mar 11, 2020
@alexcrichton
Temporarily remove support for interface types
eb175ab 
This commit temporarily removes support for interface types from the
`wasmtime` CLI and removes the `wasmtime-interface-types` crate. An
error is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:

* bytecodealliance#677 - tracking work for re-adding interface types support
* bytecodealliance#1271 - rationale for removal and links to other discussions

Closes bytecodealliance#1271
@alexcrichton alexcrichton mentioned this issue Mar 11, 2020
Merged
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Mar 12, 2020
@alexcrichton
Temporarily remove support for interface types
9a74402 
This commit temporarily removes support for interface types from the
`wasmtime` CLI and removes the `wasmtime-interface-types` crate. An
error is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:

* bytecodealliance#677 - tracking work for re-adding interface types support
* bytecodealliance#1271 - rationale for removal and links to other discussions

Closes bytecodealliance#1271
alexcrichton added a commit that referenced this issue Mar 12, 2020
@alexcrichton
Temporarily remove support for interface types (#1292)
34f768d 
* Temporarily remove support for interface types

This commit temporarily removes support for interface types from the
`wasmtime` CLI and removes the `wasmtime-interface-types` crate. An
error is now printed for any input wasm modules that have wasm interface
types sections to indicate that support has been removed and references
to two issues are printed as well:

* #677 - tracking work for re-adding interface types support
* #1271 - rationale for removal and links to other discussions

Closes #1271

* Update the python extension
abrown added a commit to abrown/wasmtime that referenced this issue Mar 18, 2020
@abrown
Remove packed_struct dependency; closes bytecodealliance#1271 and byt…
d4df756 
…ecodealliance#1284 (bytecodealliance#1282)
@psarna psarna mentioned this issue Aug 2, 2021
Merged
@rihp rihp mentioned this issue Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wasmtime Issues about wasmtime that don't fall into another label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporarily remove support for interface types alexcrichton/wasmtime
1 participant
@alexcrichton