Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability (to cranelift) to generate .eh_frame #1282

Open
yurydelendik opened this issue Mar 11, 2020 · 5 comments
Open

Add capability (to cranelift) to generate .eh_frame #1282

yurydelendik opened this issue Mar 11, 2020 · 5 comments
Labels
cranelift Issues related to the Cranelift code generator help wanted

Comments

@yurydelendik
Copy link
Contributor

This is a continuation of #53

We save .debug_frame section in wasmtime's JIT and wasm2obj. It will be nice to move this capability to the cranelift level (e.g. cranelift-faerie?).

This issue may intersect with #1181 for linux and macos platforms.

@bjorn3
Copy link
Contributor

bjorn3 commented Mar 11, 2020

e.g. cranelift-faerie?

Rather add common code to for example cranelift-module and then implement this in both cranelift-faerie and cranelift-object.

@iximeow
Copy link
Contributor

iximeow commented Mar 11, 2020

Should I rebase bytecodealliance/cranelift#902 against wasmtime? That PR added this feature to cranelift-faerie, though I had taken the lack of approval and your comment about cranelift-module to be a request for an approach more like #1181 (less focused on cranelift-faerie specifically)

@marmistrz
Copy link
Contributor

Why does this issue close #1284? These two changes seem completely unrelated

@bjorn3
Copy link
Contributor

bjorn3 commented Mar 18, 2020

Cranelift recently got merged into the wasmtime repo. All issues have been migrated to the wasmtime repo, but this has renumbered all cranelift issues.

@bnjbvr bnjbvr added the cranelift Issues related to the Cranelift code generator label Apr 1, 2020
@github-actions
Copy link

github-actions bot commented Apr 1, 2020

Subscribe to Label Action

This issue or pull request has been labeled: "cranelift"

Users Subscribed to "cranelift"

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator help wanted
Projects
None yet
Development

No branches or pull requests

5 participants