Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for fs-set-times to 3.1 #2705

Conversation

jlb6740
Copy link
Contributor

@jlb6740 jlb6740 commented Mar 4, 2021

Received a compile error:

Compiling wasi-cap-std-sync v0.23.0 (/home/jlbirch/wasmtime_jlb6740/crates/wasi-common/cap-std-sync)
error[E0599]: the method set_times exists for struct cap_std::fs::File, but its trait bounds were not satisfied
--> crates/wasi-common/cap-std-sync/src/file.rs:84:14
|
84 | .set_times(convert_systimespec(atime), convert_systimespec(mtime))?;
| ^^^^^^^^^ method cannot be called on cap_std::fs::File due to unsatisfied trait bounds
|
::: /home/jlbirch/.cargo/registry/src/github.com-1ecc6299db9ec823/cap-std-0.13.7/src/fs/file.rs:32:1
|
32 | pub struct File {
| ---------------
| |
| doesn't satisfy _: unsafe_io::unsafe_handle::AsUnsafeFile
| doesn't satisfy cap_std::fs::File: SetTimes
|
= note: the following trait bounds were not satisfied:
cap_std::fs::File: unsafe_io::unsafe_handle::AsUnsafeFile
which is required by cap_std::fs::File: SetTimes
= help: items from traits can only be used if the trait is in scope
= note: the following trait is implemented but not in scope; perhaps add a use for it:
use fs_set_times::set_times::SetTimes;

warning: unused import: SetTimes
--> crates/wasi-common/cap-std-sync/src/file.rs:2:20
|
2 | use fs_set_times::{SetTimes, SystemTimeSpec};
| ^^^^^^^^
|
= note: #[warn(unused_imports)] on by default

error: aborting due to previous error; 1 warning emitted

For more information about this error, try rustc --explain E0599.
error: could not compile wasi-cap-std-sync

I believe this version bump is the correct solution .. though there is a chance this could just be my system after some recent updates to my environment.

@jlb6740 jlb6740 force-pushed the update-fs-set-times-version-to-3.1 branch 3 times, most recently from 3c8a24d to 6576b8d Compare March 4, 2021 08:29
@jlb6740
Copy link
Contributor Author

jlb6740 commented Mar 4, 2021

Not clear why CI is choking on duplicate crate entry error. Will retrigger in a bit.

@github-actions github-actions bot added the wasi Issues pertaining to WASI label Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

Subscribe to Label Action

cc @kubkon

This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@sunfishcode
Copy link
Member

This is caused by me making what turned out to be semver-incompatible changes, while not bumping the semver versions. The fix is to also update cap-*, unsafe-io, and system-interface to their latest versions as well.

@jlb6740 jlb6740 force-pushed the update-fs-set-times-version-to-3.1 branch 3 times, most recently from 61f930b to 192458d Compare March 4, 2021 18:10
@jlb6740
Copy link
Contributor Author

jlb6740 commented Mar 4, 2021

@sunfishcode Thanks! I think it's happy.

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@sunfishcode sunfishcode merged commit 2190fb6 into bytecodealliance:main Mar 4, 2021
@radu-matei
Copy link
Member

Will there be a patch update with this fix, @sunfishcode?

@sunfishcode
Copy link
Member

Ah, is this affecting downstream users of wasmtime? If so, I'll do a release.

@sunfishcode sunfishcode mentioned this pull request Mar 4, 2021
@sunfishcode
Copy link
Member

I've now filed #2707 to start the process for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants