-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasmtime 0.24.0 #2707
Wasmtime 0.24.0 #2707
Conversation
I used a specially modified version of the publish script to avoid bumping the `witx` version.
I think it's fine to have a release of wamtime, but for this problem specifically it seems like the best solution would be to yank the versions of crates on crates.io that have the breaking change? That would keep wasmtime-working as-is (and anyone else depending on the crates) |
I don't have an opinion on the right way to fix the semver issue above, but if this wasn't too much burden, it would be pretty nice to have a release that contained the fix provided in #2664 (this new released version would be the first one to include it). |
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "cranelift:area:peepmatic", "cranelift:meta", "cranelift:module", "cranelift:wasm", "wasmtime:docs"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sounds like we should do both then. I'll figure out exactly what needs to be yanked, but since I already have this PR ready to go, we can also do a release. Anyone want to approve this PR? :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As reported in #2705, I made some semver-incompatible changes related to fs-set-times without properly bumping semver. This release is prompted by the need to update wasmtime past the problematic version. But this also happens to be a change to release the
async
functions support!