x64: Fix ISA requirement for pmaddubsw
#6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
requested review from
abrown and
pchickey
and removed request for
a team
abrown
approved these changes
Jun 22, 2023
github-actions
bot
added
cranelift
This was erroneously listed as SSE2 but this is actually an SSSE3 instruction. This commit updates the ISA requirement as well as related lowerings to have everything work with an SSE2 baseline as well which is mostly plumbing to make sure the relaxed-simd dot product instructions use it when it's available but otherwise fall-back to the deterministic lowering.
alexcrichton
force-pushed
the
x64-sse2-pmaddubsw
branch
from
51b682f to
9b412a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was erroneously listed as SSE2 but this is actually an SSSE3 instruction. This commit updates the ISA requirement as well as related lowerings to have everything work with an SSE2 baseline as well which is mostly plumbing to make sure the relaxed-simd dot product instructions use it when it's available but otherwise fall-back to the deterministic lowering.