Enable some miscellaneous Wasm GC spec tests; fix module import/export linking and subtyping #9446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These weren't caught by our checks that `should_fail` tests do not pass, I think because they only contain modules that should validate, and not any actual assertions.
We were previously incorrectly doing a (shallow) match on structure when we should have been doing a subtyping check.
fitzgen
force-pushed
the
enable-misc-gc-spec-tests
branch
from
c015e18
to
7e78047
Compare
alexcrichton
approved these changes
Oct 10, 2024
| @@ -203,15 +203,8 @@ fn should_fail(test: &Path, strategy: Strategy) -> bool { | |||
| } | |||
| } | |||
| } | |||
| let unsupported_gc_tests = [ | |||
| "binary_gc.wast", | |||
There was a problem hiding this comment.
Looks like some of these were because there weren't any actual files of that name, so must have been from some historical version of the gc proposal's spec tests or something like that?
There was a problem hiding this comment.
I think maybe some didn't have any assertions either? I don't know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.