Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable some miscellaneous Wasm GC spec tests; fix module import/export linking and subtyping #9446

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Enable some miscellaneous Wasm GC spec tests; fix module import/export linking and subtyping #9446

merged 2 commits into from
Oct 10, 2024

Commits on Oct 10, 2024

  1. Enable some miscellaneous GC spec tests 

    These weren't caught by our checks that `should_fail` tests do not pass, I think
because they only contain modules that should validate, and not any actual
assertions.
    @fitzgen
    fitzgen committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a96e33e View commit details
    Browse the repository at this point in the history

  2. Require declared subtyping when linking module import/export functions 

    We were previously incorrectly doing a (shallow) match on structure when we
should have been doing a subtyping check.
    @fitzgen
    fitzgen committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7e78047 View commit details
    Browse the repository at this point in the history