Alpine Dockerfile with Lua #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better wording
zh-jq-b
reviewed
Aug 21, 2024
g3proxy/docker/lua.alpine.Dockerfile
Outdated
| ENV PKG_CONFIG_PATH=/usr/lib/pkgconfig | ||
| RUN cargo build --profile release-lto \ | ||
| --no-default-features --features quic,c-ares,hickory,lua54 \ | ||
| -p g3proxy -p g3proxy-ctl |
There was a problem hiding this comment.
You may also want to compile in g3proxy-lua, which can be used to verify the call result of the script
There was a problem hiding this comment.
Append -p g3proxy-lua to line 18?
There was a problem hiding this comment.
okay you got it, I'll add that tonight after testing it.
There was a problem hiding this comment.
I've added the bit of code but it doesn't work.
Inside the container, after rebuilding and running:
ls /usr/bin/g3proxy
g3proxy g3proxy-ctlThere's no g3proxy-lua binary.
There was a problem hiding this comment.
COPY is also needed in the final build step.
|
Is it possible to use dynamic linking? I see nginx-mod-http-lua is available in alpine, which seems to be dynamic linked. |
|
|
|
I'll look into this a bit more tonight. I forgot to note this is my first time using Lua. Also, I don't have a compiled language background - so I don't think I can be of much help in regards to static/dynamic linking. Actually, I'll have to move away from Lua to Python because Lua doesn't have first-party Google Cloud support (no SDKs). After I do that, I'll contribute the Python Dockerfile as well. |
|
you can support both lua and python features in the same docker file. It has to be dynamic linked to be able to call c based lua/python libs I guess. |
|
I looked into the comment you posted, which led me to learn a bit about musl, and frankly I've no idea about all this dynamic and static linking. I can't even conceptualize it, really.. It's ok. I'll add Python, and if you wanna take it further, that's great. |
|
I will switch the default alpine build to use dynamic first, then you can sync the changes to this script-enabled docker build file. |
|
6f21d54 updated to use dynamic linking |
|
I added the missing COPY g3proxy-lua |
zh-jq
requested changes
Aug 24, 2024
|
Done both, error is during build, during |
|
It seems that package |
zh-jq-b
reviewed
Aug 26, 2024
zh-jq-b
reviewed
Aug 26, 2024
|
It builds, but here's what happens next. |
|
You need to install the missing dynamic libs before COPY. |
|
Got it, I'll be pushing that tonight after testing. |
|
runs after 736e36d as per your comment |
zh-jq
approved these changes
Aug 28, 2024
NinoSkopac
commented
Aug 28, 2024
| # beware: lua's c modules (e.g. cjson) | ||
| # need to be statically linked | ||
| # and won't work when installing in | ||
| # alpine via luarocks. |
There was a problem hiding this comment.
this comment is no longer valid. fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For running Lua auth in containers.
Makes installing Lua modules easy via
luarocks.