Spinnaker 3.0.0.118 upgrade

[ds58]

I upgraded the spinnaker preset to the latest Spinnaker SDK version 3.0.0.118

Had to change a few things in the sample code, nothing major.

I added a few skips for some enum symbols I wasn't sure how to deal with:

enum TLPayloadType
{
    ...
    SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID = 1000, /* Starting value for GenTL Producer custom IDs*/
    SPINNAKER_TLPAYLOAD_TYPE_LOSSLESS_COMPRESSED = SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID + 1,
    SPINNAKER_TLPAYLOAD_TYPE_LOSSY_COMPRESSED = SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID + 2,
    SPINNAKER_TLPAYLOAD_TYPE_JPEG_LOSSLESS_COMPRESSED = SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID + 3

In Java, it maps to

public enum spinTLPayloadType {
    ...
    SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID(1000), /* Starting value for GenTL Producer custom IDs*/
    SPINNAKER_TLPAYLOAD_TYPE_LOSSLESS_COMPRESSED(SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID + 1),
    SPINNAKER_TLPAYLOAD_TYPE_LOSSY_COMPRESSED(SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID + 2),
    SPINNAKER_TLPAYLOAD_TYPE_JPEG_LOSSLESS_COMPRESSED(SPINNAKER_TLPAYLOAD_TYPE_CUSTOM_ID + 3);

I couldn't find any examples on how to deal with "self referencing enums." Any thoughts?

[saudet]

I couldn't find any examples on how to deal with "self referencing enums." Any thoughts?

That should be working. It's a bug in JavaCPP, I guess, but are those enums important?

[ds58]

Those enums aren't really important from what I can tell

[calvertdw]

It looks like an outdated actions.yml was used for the build, pulling the old Spinnaker downloads. 🤔

[saudet]

To test that, we would need to replace temporarily bytedeco/javacpp-presets/.github/actions/deploy-[...]@actions with ihmcrobotics/javacpp-presets/.github/actions/deploy-[...]@spinnaker-upgrade in https://github.com/ihmcrobotics/javacpp-presets/blob/spinnaker-upgrade/.github/workflows/spinnaker.yml

[saudet]

Could we get this tested as per #1313 (comment)?

[saudet]

Ok, this looks good to merge. Please revert 2f0759d and let's get this in!