Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock on ffmpeg+x264 for windows encode with tune=zerolatency #481

Merged
merged 2 commits into from
Nov 24, 2017

Conversation

n-kai-cj
Copy link
Contributor

ffmpeg+x264 for windows use by default windows native threads (win32thread),
while ffmpeg+x264 in javacpp use pthread.
ffmpeg+x264 in javacpp take deadlocks in encoding
when setting tune option to zerolatency that is x264's option.

ffmpeg+x264 for windows use by default windows native threads (win32thread),
while ffmpeg+x264 in javacpp use pthread.
ffmpeg+x264 in javacpp take deadlocks in encoding
when setting tune option to zerolatency that is x264's option.
@saudet
Copy link
Member

saudet commented Nov 11, 2017

Seems to be working fine now, yes. Please remove the remaining "--disable-w32threads" and "--enable-pthreads" and we can merge this I think. Thanks!

@n-kai-cj
Copy link
Contributor Author

n-kai-cj commented Nov 12, 2017

Thank you quick response @saudet !!
I have to close this issue and pull request?

@saudet
Copy link
Member

saudet commented Nov 16, 2017

No, you can make modifications by pushing commits to the branch you created on your fork. They will automatically appear in this pull request.

@saudet saudet merged commit d979e74 into bytedeco:master Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants