log-source-app should not be a Diagnostic Logs client.

It's just a server for logs. project-chip#29660
bzbarsky-apple · Oct 9, 2023 · 1d7e81f · 1d7e81f
1 parent 3dfffe7
commit 1d7e81f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 54 deletions.
diff --git a/examples/log-source-app/log-source-common/log-source-app.matter b/examples/log-source-app/log-source-common/log-source-app.matter
@@ -268,51 +268,6 @@ server cluster NetworkCommissioning = 49 {
  command access(invoke: administer) ReorderNetwork(ReorderNetworkRequest): NetworkConfigResponse = 8;
 }
 
-/** The cluster provides commands for retrieving unstructured diagnostic logs from a Node that may be used to aid in diagnostics. */
-client cluster DiagnosticLogs = 50 {
- enum IntentEnum : ENUM8 {
- kEndUserSupport = 0;
- kNetworkDiag = 1;
- kCrashLogs = 2;
- }
-
- enum StatusEnum : ENUM8 {
- kSuccess = 0;
- kExhausted = 1;
- kNoLogs = 2;
- kBusy = 3;
- kDenied = 4;
- }
-
- enum TransferProtocolEnum : ENUM8 {
- kResponsePayload = 0;
- kBDX = 1;
- }
-
- readonly attribute command_id generatedCommandList[] = 65528;
- readonly attribute command_id acceptedCommandList[] = 65529;
- readonly attribute event_id eventList[] = 65530;
- readonly attribute attrib_id attributeList[] = 65531;
- readonly attribute bitmap32 featureMap = 65532;
- readonly attribute int16u clusterRevision = 65533;
-
- request struct RetrieveLogsRequestRequest {
- IntentEnum intent = 0;
- TransferProtocolEnum requestedProtocol = 1;
- optional CHAR_STRING<32> transferFileDesignator = 2;
- }
-
- response struct RetrieveLogsResponse = 1 {
- StatusEnum status = 0;
- LONG_OCTET_STRING logContent = 1;
- optional epoch_us UTCTimeStamp = 2;
- optional systime_us timeSinceBoot = 3;
- }
-
- /** Retrieving diagnostic logs from a Node */
- command RetrieveLogsRequest(RetrieveLogsRequestRequest): RetrieveLogsResponse = 0;
-}
-
 /** The cluster provides commands for retrieving unstructured diagnostic logs from a Node that may be used to aid in diagnostics. */
 server cluster DiagnosticLogs = 50 {
  enum IntentEnum : ENUM8 {
@@ -468,7 +423,6 @@ server cluster OperationalCredentials = 62 {
 endpoint 0 {
  device type ma_all_clusters_app = 0, version 1;
 
- binding cluster DiagnosticLogs;
 
  server cluster AccessControl {
  emits event AccessControlEntryChanged;

diff --git a/examples/log-source-app/log-source-common/log-source-app.zap b/examples/log-source-app/log-source-common/log-source-app.zap
@@ -470,14 +470,6 @@
  }
  ]
  },
- {
- "name": "Diagnostic Logs",
- "code": 50,
- "mfgCode": null,
- "define": "DIAGNOSTIC_LOGS_CLUSTER",
- "side": "client",
- "enabled": 1
- },
  {
  "name": "Diagnostic Logs",
  "code": 50,