Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove client side cluster for Diagnostic Logs in log source app's zap file #29660

Closed
brdandu opened this issue Oct 9, 2023 · 0 comments · Fixed by #29662
Closed

Remove client side cluster for Diagnostic Logs in log source app's zap file #29660

brdandu opened this issue Oct 9, 2023 · 0 comments · Fixed by #29662
Labels
bug Something isn't working needs triage

Comments

@brdandu
Copy link
Contributor

brdandu commented Oct 9, 2023

Reproduction steps

Currently if you open the log source app you will see that the Diagnostic's cluster is enabled on the client side which is not in compliance with the spec. This app needs to disable the client side cluster

Bug prevalence

Always

GitHub hash of the SDK that was being used

52225dd

Platform

other

Platform Version(s)

No response

Anything else?

No response
@brdandu brdandu added bug Something isn't working needs triage labels Oct 9, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 9, 2023
@bzbarsky-apple
log-source-app should not be a Diagnostic Logs client.
1d7e81f 
It's just a server for logs.

project-chip#29660
@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 9, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Oct 9, 2023
@bzbarsky-apple
log-source-app should not be a Diagnostic Logs client.
5797579 
It's just a server for logs.

Fixes project-chip#29660
@mergify mergify bot closed this as completed in #29662 Oct 10, 2023
mergify bot pushed a commit that referenced this issue Oct 10, 2023
@bzbarsky-apple
log-source-app should not be a Diagnostic Logs client. (#29662)
3701286 
It's just a server for logs.

Fixes #29660
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
log-source-app should not be a Diagnostic Logs client. (project-chip#…
fe5f4d6 
…29662)

It's just a server for logs.

Fixes project-chip#29660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log-source-app should not be a Diagnostic Logs client. bzbarsky-apple/connectedhomeip
1 participant
@brdandu