Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled searching for Germline in the protein change column #1152

Merged
merged 2 commits into from
May 29, 2018
Merged

Enabled searching for Germline in the protein change column #1152

merged 2 commits into from
May 29, 2018

Conversation

onursumer
Copy link
Member

What? Why?

Fix cBioPortal/cbioportal#4180

Checks

  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!
  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Airbnb React/JSX Style guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)

@onursumer onursumer force-pushed the protein-change-germline-search branch 2 times, most recently from c9e5c82 to a214673 Compare May 14, 2018 16:37
@onursumer onursumer force-pushed the protein-change-germline-search branch from a214673 to f27892a Compare May 21, 2018 18:42
@inodb inodb merged commit 7fd05b7 into cBioPortal:master May 29, 2018
@onursumer onursumer deleted the protein-change-germline-search branch May 29, 2018 17:47
inodb added a commit to cBioPortal/cbioportal that referenced this pull request May 29, 2018
@inodb
update frontend version (v1.13.0-draft)
a754bd9 
- Oncoprint tracks indicating profiled status in queried profiles (cBioPortal/cbioportal-frontend#1167)
- Prevent alphabetical searching example queries list (cBioPortal/cbioportal-frontend#1177)
- Fix missing modify query button for subset of virtual study (cBioPortal/cbioportal-frontend#1176)
- Fix broken CN segments file (cBioPortal/cbioportal-frontend#1175)
- Enable searching for germline in protein change column (cBioPortal/cbioportal-frontend#1152)
- Open mycancergenome links in separate tab (cBioPortal/cbioportal-frontend#1188)
- Fix copy button behavior (cBioPortal/cbioportal-frontend#1190)
- Remove semicolon from custom news section (cBioPortal/cbioportal-frontend#1194)
- Don't show invalid allele count values e.g. N/A, undefined, -1 in mutations table (cBioPortal/cbioportal-frontend#1165)
- Remove dependency on pdb annotation service (use genomenexus.org instead) (cBioPortal/cbioportal-frontend#1068)
- Fix genomic overview when it contains `.` in the filename (cBioPortal/cbioportal-frontend#1094)
@inodb inodb mentioned this pull request May 29, 2018
Closed
inodb added a commit to cBioPortal/cbioportal that referenced this pull request May 29, 2018
@inodb
update frontend version (v1.13.1-draft)
64068cc 
- Oncoprint tracks indicating profiled status in queried profiles (cBioPortal/cbioportal-frontend#1167)
- Prevent alphabetical searching example queries list (cBioPortal/cbioportal-frontend#1177)
- Fix missing modify query button for subset of virtual study (cBioPortal/cbioportal-frontend#1176)
- Fix broken CN segments file (cBioPortal/cbioportal-frontend#1175)
- Enable searching for germline in protein change column (cBioPortal/cbioportal-frontend#1152)
- Open mycancergenome links in separate tab (cBioPortal/cbioportal-frontend#1188)
- Fix copy button behavior (cBioPortal/cbioportal-frontend#1190)
- Remove semicolon from custom news section (cBioPortal/cbioportal-frontend#1194)
- Don't show invalid allele count values e.g. N/A, undefined, -1 in mutations table (cBioPortal/cbioportal-frontend#1165)
- Remove dependency on pdb annotation service (use genomenexus.org instead) (cBioPortal/cbioportal-frontend#1068)
- Fix genomic overview when it contains `.` in the filename (cBioPortal/cbioportal-frontend#1094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamabeshouse adamabeshouse adamabeshouse approved these changes

@alisman alisman Awaiting requested review from alisman

@inodb inodb Awaiting requested review from inodb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onursumer @adamabeshouse @inodb