Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent alphabetical sorting of items in example search list of query… #1177

Merged
merged 1 commit into from
May 17, 2018

Conversation

alisman
Copy link
Collaborator

@alisman alisman commented May 16, 2018

Be default the AutoSuggest component sorts the example query items alphabetically. We don't want this.

Result:
image

What? Why?

Fix # .

Changes proposed in this pull request:

  • a
  • b

Checks

  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!
  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Airbnb React/JSX Style guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. GifGrabber.

Notify reviewers

Read our Pull request merging
policy
. If you are part of the
cBioPortal organization, notify the approprate team (remove inappropriate):

@cBioPortal/frontend

If you are not part of the cBioPortal organization look at who worked on the
file before you. Please use git blame <filename> to determine that
and notify them here:

@alisman alisman requested review from inodb and jjgao May 16, 2018 16:30
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alisman alisman merged commit cd52420 into cBioPortal:master May 17, 2018
@alisman alisman deleted the searchExample branch May 17, 2018 20:59
inodb added a commit to cBioPortal/cbioportal that referenced this pull request May 29, 2018
- Oncoprint tracks indicating profiled status in queried profiles (cBioPortal/cbioportal-frontend#1167)
- Prevent alphabetical searching example queries list (cBioPortal/cbioportal-frontend#1177)
- Fix missing modify query button for subset of virtual study (cBioPortal/cbioportal-frontend#1176)
- Fix broken CN segments file (cBioPortal/cbioportal-frontend#1175)
- Enable searching for germline in protein change column (cBioPortal/cbioportal-frontend#1152)
- Open mycancergenome links in separate tab (cBioPortal/cbioportal-frontend#1188)
- Fix copy button behavior (cBioPortal/cbioportal-frontend#1190)
- Remove semicolon from custom news section (cBioPortal/cbioportal-frontend#1194)
- Don't show invalid allele count values e.g. N/A, undefined, -1 in mutations table (cBioPortal/cbioportal-frontend#1165)
- Remove dependency on pdb annotation service (use genomenexus.org instead) (cBioPortal/cbioportal-frontend#1068)
- Fix genomic overview when it contains `.` in the filename (cBioPortal/cbioportal-frontend#1094)
inodb added a commit to cBioPortal/cbioportal that referenced this pull request May 29, 2018
- Oncoprint tracks indicating profiled status in queried profiles (cBioPortal/cbioportal-frontend#1167)
- Prevent alphabetical searching example queries list (cBioPortal/cbioportal-frontend#1177)
- Fix missing modify query button for subset of virtual study (cBioPortal/cbioportal-frontend#1176)
- Fix broken CN segments file (cBioPortal/cbioportal-frontend#1175)
- Enable searching for germline in protein change column (cBioPortal/cbioportal-frontend#1152)
- Open mycancergenome links in separate tab (cBioPortal/cbioportal-frontend#1188)
- Fix copy button behavior (cBioPortal/cbioportal-frontend#1190)
- Remove semicolon from custom news section (cBioPortal/cbioportal-frontend#1194)
- Don't show invalid allele count values e.g. N/A, undefined, -1 in mutations table (cBioPortal/cbioportal-frontend#1165)
- Remove dependency on pdb annotation service (use genomenexus.org instead) (cBioPortal/cbioportal-frontend#1068)
- Fix genomic overview when it contains `.` in the filename (cBioPortal/cbioportal-frontend#1094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants