Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plots tab - filter out nan data #1380

Merged
merged 1 commit into from
Aug 15, 2018
Merged

plots tab - filter out nan data #1380

merged 1 commit into from
Aug 15, 2018

Conversation

adamabeshouse
Copy link
Contributor

No description provided.

@adamabeshouse adamabeshouse mentioned this pull request Aug 14, 2018
Closed
@adamabeshouse adamabeshouse force-pushed the plots-nan branch 2 times, most recently from c394ea6 to 6286c2e Compare August 14, 2018 20:39
pieterlukasse
pieterlukasse approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@pieterlukasse pieterlukasse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
A heads up: at some point we want to introduce support for ">" in values, e.g. ">10" (we thinking about it now in our design for drug response data). So we might come back to this later.

@pieterlukasse
Copy link
Member

pieterlukasse commented Aug 15, 2018 •
edited
Loading

small detail: maybe cover this with a regression test?

plots tab - filter out nan data
48633b5 
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
@adamabeshouse adamabeshouse merged commit 64b4582 into cBioPortal:master Aug 15, 2018
@adamabeshouse adamabeshouse deleted the plots-nan branch August 15, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieterlukasse pieterlukasse pieterlukasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamabeshouse @pieterlukasse