-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of treatment response data in OncoPrint tab #2053
Merged
inodb
merged 1 commit into
cBioPortal:rc
from
thehyve:treatment_response_feature_heatmap_selection
Jul 3, 2019
Merged
Integration of treatment response data in OncoPrint tab #2053
inodb
merged 1 commit into
cBioPortal:rc
from
thehyve:treatment_response_feature_heatmap_selection
Jul 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
2 times, most recently
from
March 13, 2019 07:30
bd48d5b
to
ce3264b
Compare
pvannierop
added
ready to review
hyve
rc
results.oncoprint
feature
and removed
DO NOT MERGE
labels
Mar 13, 2019
pvannierop
changed the base branch from
treatment_response_feature_oncoprint
to
rc
March 13, 2019 07:35
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
from
March 13, 2019 07:41
ce3264b
to
348215f
Compare
pvannierop
changed the title
Improved treatment selection menu in OncoPrint heatmap menu
Integration of treatment response data in OncoPrint tab
Mar 13, 2019
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
from
March 14, 2019 09:28
77293e7
to
f24ea3e
Compare
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
from
March 18, 2019 09:41
f24ea3e
to
d8a79f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure to remove yarn-error.log
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
from
March 25, 2019 13:27
9adc8ac
to
21874e4
Compare
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
10 times, most recently
from
June 27, 2019 09:36
7e51378
to
b60ff0b
Compare
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
15 times, most recently
from
July 3, 2019 13:42
af6a5e3
to
1d1054d
Compare
pvannierop
force-pushed
the
treatment_response_feature_heatmap_selection
branch
from
July 3, 2019 16:23
d04f351
to
ab01c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This PR will implement handling of the new
treatment response
(genetic entity) data type by the OncoPrint component (see this backend PR). The selection of treatments to be shown on the oncoprint does not occur on the Query page but in the heatmap menu. For this reason identifier validation as used for gene names on the query page does not support the user in entering valid identifiers. This PR will improve selection of treatments in the heatmap menu by allowing selection of treatments from a select box and by parsing identifiers typed by the user.Changes
Add Treatments to Heatmap
button.>
or<
prefixes to values. Heatmap track for treatment profiles are represented with a new legend type that shows continuous values (gradient) and truncated values (categories) (see Fig.2). Clustering of treatment heatmap tracks that contain truncated values used the truncated value for respective samples (for example 8 represents truncated value >8).Notes
Images
Figure 1
Figure 2
Figure 3
Figure 4
BACKEND_BRANCH=thehyve:treatment_study_implementation_rebased