Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of treatment response data in OncoPrint tab #2053

Merged

Conversation

pvannierop
Copy link
Contributor

@pvannierop pvannierop commented Feb 20, 2019

What? Why?

This PR will implement handling of the new treatment response (genetic entity) data type by the OncoPrint component (see this backend PR). The selection of treatments to be shown on the oncoprint does not occur on the Query page but in the heatmap menu. For this reason identifier validation as used for gene names on the query page does not support the user in entering valid identifiers. This PR will improve selection of treatments in the heatmap menu by allowing selection of treatments from a select box and by parsing identifiers typed by the user.

Changes

  • Treatment response profiles are shown in the heatmap menu (when available in cBioPortal db) (see Fig.1). When a treatment response value is selected, treatments can be added as a heatmap track by pressing the Add Treatments to Heatmap button.
  • Treatment data points can be truncated (real value lies beyond a certain value) which can be indicated by > or < prefixes to values. Heatmap track for treatment profiles are represented with a new legend type that shows continuous values (gradient) and truncated values (categories) (see Fig.2). Clustering of treatment heatmap tracks that contain truncated values used the truncated value for respective samples (for example 8 represents truncated value >8).
  • Tooltips on a treatment heatmap track contain an url to external websites (when defined in cbioportal db) (see Fig.2).
  • Entries in the treatment select box can be filtered for key-words (looks in stable_id, name and description fields for treatments) (see Fig.3). Individual treatments can be selected with check boxes. All treatments can be (de-)selected using buttons (see Fig.3).
  • Selected treatments are displayed in the menu as icons (see Fig.4). Treatments can be removed by pressing the X-button in respective icons.
  • Treatment identifiers can be typed in the free text area. Recognized treatments are added as icon above, and selected in the treatment selection menu (see Fig.4).

Notes

  • This PR should be merged after this frontend PR.
  • A similar menu for genes can be implemented, but is not included in this PR.

Images

Figure 1

  • Selection box for treatments is displayed when treatment profile is selected.
    screenshot from 2019-02-20 13-46-05

Figure 2

  1. Treatment profile shown as heatmap track
  2. New legend type with continuous and truncated values
  3. URL in tooltip of treatment heatmap tracks
    screenshot from 2019-02-20 13-16-24

Figure 3

  • Filtering of treatments in the selection box
  • Selection of treatment via check box
  • Buttons for selection and deselection of all treatments
    screenshot from 2019-02-20 13-46-53

Figure 4

  • Selected treatments are show as icons
  • Icons have a X-button used to remove a selected treatment
  • A recognized treatment identifier in the text-area is added as a
    screenshot from 2019-02-20 13-47-43
    screenshot from 2019-02-20 13-57-53

BACKEND_BRANCH=thehyve:treatment_study_implementation_rebased

@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch 2 times, most recently from bd48d5b to ce3264b Compare March 13, 2019 07:30
@pvannierop pvannierop changed the base branch from treatment_response_feature_oncoprint to rc March 13, 2019 07:35
@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch from ce3264b to 348215f Compare March 13, 2019 07:41
@pvannierop pvannierop changed the title Improved treatment selection menu in OncoPrint heatmap menu Integration of treatment response data in OncoPrint tab Mar 13, 2019
env/custom.sh Outdated Show resolved Hide resolved
src/pages/resultsView/ResultsViewPageStore.ts Show resolved Hide resolved
src/pages/resultsView/plots/PlotsTabUtils.tsx Outdated Show resolved Hide resolved
src/shared/components/oncoprint/DataUtils.ts Outdated Show resolved Hide resolved
src/shared/components/oncoprint/DeltaUtils.spec.ts Outdated Show resolved Hide resolved
src/shared/components/oncoprint/ResultsViewOncoprint.tsx Outdated Show resolved Hide resolved
src/shared/components/oncoprint/TooltipUtils.ts Outdated Show resolved Hide resolved
src/shared/components/textIconArea/TextIconArea.tsx Outdated Show resolved Hide resolved
@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch from 77293e7 to f24ea3e Compare March 14, 2019 09:28
@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch from f24ea3e to d8a79f9 Compare March 18, 2019 09:41
Copy link
Contributor

@adamabeshouse adamabeshouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure to remove yarn-error.log

@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch from 9adc8ac to 21874e4 Compare March 25, 2019 13:27
@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch 10 times, most recently from 7e51378 to b60ff0b Compare June 27, 2019 09:36
@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch 15 times, most recently from af6a5e3 to 1d1054d Compare July 3, 2019 13:42
@pvannierop pvannierop force-pushed the treatment_response_feature_heatmap_selection branch from d04f351 to ab01c09 Compare July 3, 2019 16:23
@inodb inodb merged commit 3d60fcb into cBioPortal:rc Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants