Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar chart selection bug #4154

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

onursumer
Copy link
Member

Fix cBioPortal/cbioportal#9173

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer requested review from inodb and leexgh January 27, 2022 21:19
Copy link
Member

@leexgh leexgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@onursumer onursumer force-pushed the fix-bar-chart-selection-bug branch from 70327c5 to 27b4614 Compare January 31, 2022 17:51
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat - thanks!

@inodb inodb added the bug label Jan 31, 2022
@inodb inodb merged commit e2cc529 into cBioPortal:master Jan 31, 2022
@onursumer onursumer deleted the fix-bar-chart-selection-bug branch March 8, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

histogram issue when selecting == or > bar
3 participants