Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram issue when selecting == or > bar #9173

Closed
inodb opened this issue Jan 4, 2022 · 2 comments · Fixed by cBioPortal/cbioportal-frontend#4154
Closed

histogram issue when selecting == or > bar #9173

inodb opened this issue Jan 4, 2022 · 2 comments · Fixed by cBioPortal/cbioportal-frontend#4154

Comments

@inodb
Copy link
Member

inodb commented Jan 4, 2022

From @tmazor: If I select the >14 bar, the histogram highlights both the 14 & >14 bars
image
I think the filter that gets applied is correct (header is right and when I browsed Clinical Data tab, all counts were 15+), but the histogram is misleading.
I don't see this happening with other histograms, so I suspect this is again related to the fact that each bar here is a single value.

@onursumer
Copy link
Member

When we select both 14 and >14 the bar chart display is correct but the header is misleading this time. It still shows >14 but it should be >=14.

So, this is a frontend issue where we incorrectly interpret and render the applied filters. We need to fix both BarChart.tsx and UserSelections.tsx components in order to display the selected filters properly. It's probably a better idea to create a separate issue for the user selections component though.

@inodb
Copy link
Member Author

inodb commented Jan 31, 2022

follow up in #9266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants