Add property to define custom sample type colors in patient view

[BasLee]

Extend the legend colors of sample types in the patient view by configuring custom sample types with a backend property.
Depends on: cBioPortal/cbioportal#10336.

Example of a patient view timeline with a sample of type ctDNA

Configure custom sample types and their colors in the patient view using a new property skin_patient_view_custom_sample_types like:

{
   "plasma": "gold",
   "ctdna": "lightblue",
   "urine": "yellow",
   "biopsy 3": "#00c040ff"
}

[SRodenburg]

is there a way to generate these hex codes and types instead of hard-coding a fixed amount?

[BasLee]

is there a way to generate these hex codes and types instead of hard-coding a fixed amount?

scss has methods to merge and alter colors, we could use those to create a scale

or we could create a js function that creates the colors based on the number of custom sample types there are?

[BasLee]

As discussed in the standup yesterday, the colors can now be configured along with the custom sample types in a backend. See example in PR description

[alisman]

@BasLee @pvannierop into and I think that the costum color configuration should always win out for any sample type, whether existing or custom. E.g. if I configure primary:yellow, it should override the default for that type (it doesn't now).

The name of the configuration property skin_patient_view_custom_sample_types is misleading. We're assigning custom colors to types. skin.patient.view.sample_type_colors ?

[BasLee]

I think that the costum color configuration should always win out for any sample type, whether existing or custom. E.g. if I configure primary:yellow, it should override the default for that type (it doesn't now).

The name of the configuration property skin_patient_view_custom_sample_types is misleading. We're assigning custom colors to types. skin.patient.view.sample_type_colors ?

@alisman FIxed in dc75512 and c9da654

[alisman]

https://www.cbioportal.org/patient?studyId=msk_impact_2017&caseId=P-0000015

Doesn't respect default for type=met here (should be red)

[BasLee]

Doesn't respect default for type=met here (should be red)

Fixed in a247933