Add json prop for custom patient view sample type colors #10336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
approved these changes
Aug 30, 2023
BasLee
force-pushed
the
patient-view-sample-colors-scale
branch
from
ff70205 to
957ccf7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
alisman
reviewed
Sep 5, 2023
| ### Define custom sample type colors | ||
| Define the colors of custom sample types in the patient view using a json object with for each sample type a color: | ||
| ``` | ||
| skin.patient_view.custom_sample_type_colors_json=classpath:/skin-patient-view-custom-sample-type-colors.json |
There was a problem hiding this comment.
@inodb this documentation is wrong now, correct? i mean, why is there a classpath there?
jagnathan
pushed a commit
to pughlab/cbioportal
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the legend colors of sample types in the patient view by configuring custom sample types from a json file on the classpath.
Applies the same mechanism that is used to configure default clinical tracks in the oncoprint.
See also the frontend PR: cBioPortal/cbioportal-frontend#4704