Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Feature: Introduced An Argument To Customize Timeout When Contacting API Server #106

Merged
merged 4 commits into from
Nov 7, 2024
Merged

New Feature: Introduced An Argument To Customize Timeout When Contacting API Server #106

merged 4 commits into from
Nov 7, 2024

Conversation

samuel-esp
Copy link
Collaborator

@samuel-esp samuel-esp commented Oct 22, 2024 •
edited
Loading

Motivation

In some circumstances that I still wasn't able to replicate, KubeDownscaler will timeout when processing a resources. This is most probably caused by a slow communication between the Pod and the Kubernetes API Server. This may happen because a network bottleneck or because the API Server itself is busy processing other requests

Changes

  • inside scaler.py, the pykube constant pykube.http.DEFAULT_HTTP_TIMEOUT, is set to a value that can be choosen by the user using an argument inside KubeDownscaler deployment. If the user doesn't set a value, the default is 10 (as in the previous versions)
  • Aligned KubeDownscaler to use the latest PyKube version
  • Updated few dependencies

Tests done

  • Unit Tests
  • Built Custom Image

TODO

  • I've assigned myself to this PR

@samuel-esp samuel-esp added the enhancement New feature or request label Oct 22, 2024
@samuel-esp samuel-esp self-assigned this Oct 22, 2024
@samuel-esp samuel-esp linked an issue Oct 22, 2024 that may be closed by this pull request
Failed To Process Resource: Read Timed Out #105
Closed
@samuel-esp samuel-esp changed the title New Feature: Argument To Customize API Server Timeout New Feature: Introduced An Argument To Customize Timeout When Contacting API Server Oct 22, 2024
@samuel-esp samuel-esp added the dependencies Pull requests that update a dependency file label Oct 22, 2024
@samuel-esp samuel-esp linked an issue Oct 22, 2024 that may be closed by this pull request
Fix the following vulnerabilities #103
Closed
@samuel-esp samuel-esp marked this pull request as ready for review October 28, 2024 15:08
JTaeuber
JTaeuber approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuel-esp samuel-esp merged commit a8720cd into caas-team:main Nov 7, 2024
1 check passed
This was referenced Nov 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTaeuber JTaeuber JTaeuber approved these changes

@Fovty Fovty Awaiting requested review from Fovty Fovty is a code owner

@jonathan-mayer jonathan-mayer Awaiting requested review from jonathan-mayer jonathan-mayer is a code owner

Assignees

@samuel-esp samuel-esp

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed To Process Resource: Read Timed Out Fix the following vulnerabilities
2 participants
@samuel-esp @JTaeuber