-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Retry When Detecting Concurrent Updates #113
Merged
samuel-esp
merged 10 commits into
caas-team:main
from
samuel-esp:retry-on-concurrent-updates
Nov 27, 2024
Merged
Feat: Retry When Detecting Concurrent Updates #113
samuel-esp
merged 10 commits into
caas-team:main
from
samuel-esp:retry-on-concurrent-updates
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-esp
requested review from
Fovty,
jonathan-mayer and
JTaeuber
as code owners
November 17, 2024 15:56
JTaeuber
requested changes
Nov 18, 2024
Co-authored-by: Jan <157487559+JTaeuber@users.noreply.github.com>
…sources functions
JTaeuber
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change for consistency. Other than that LGTM
JTaeuber
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the list of resources to be processed is large (e.g., 2000+ resources), the KubeDownscaler algorithm may take up to half an hour to complete its run. This can lead to the following scenario:
Even if KubeDownscaler will process the resource again during the next iteration, this could be a blocking behavior when
--once
argument is enabled on a large cluster. It could lead to some resources not being correctly processedChanges
Added a new argument --max-retries-on-conflict that allows the user to specify how many times the resource update should be retried before moving on to the next resource
Tests done
TODO