chore: Upgrade smallstep libs #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See smallstep/nosql#12 for context.
mholt
approved these changes
Aug 25, 2021
francislavoie
added a commit
that referenced
this pull request
Aug 25, 2021
Run the build with CGO enabled, to verify that the build still passes, even without installing anything extra. This test should fail if we add any dependencies that optionally uses CGO. This is an idea I had that could let us know if some change to our dependencies starts optionally using CGO. The reason this is useful is because Go actually defaults to enabling CGO if the GOOS/GOARCH build target is the same as the current platform, and CGO is supported on that platform. This means some users were Go builds of Caddy implicitly enabling CGO which would fail due to us previously having an indirect dependency on DataDog/zstd. That dependency is now gone since #4307, so we should no longer have any build issues _when enabling CGO_ if we don't have any dependencies which may optionally use CGO.
francislavoie
added a commit
that referenced
this pull request
Aug 25, 2021
Run the build with CGO enabled, to verify that the build still passes, even without installing anything extra. This test should fail if we add any dependencies that optionally uses CGO. This is an idea I had that could let us know if some change to our dependencies starts optionally using CGO. The reason this is useful is because Go actually defaults to enabling CGO if the GOOS/GOARCH build target is the same as the current platform, and CGO is supported on that platform. This means some users were Go builds of Caddy implicitly enabling CGO which would fail due to us previously having an indirect dependency on DataDog/zstd. That dependency is now gone since #4307, so we should no longer have any build issues _when enabling CGO_ if we don't have any dependencies which may optionally use CGO.
francislavoie
added a commit
that referenced
this pull request
Aug 25, 2021
Run the build with CGO enabled, to verify that the build still passes, even without installing anything extra. This test should fail if we add any dependencies that optionally uses CGO. This is an idea I had that could let us know if some change to our dependencies starts optionally using CGO. The reason this is useful is because Go actually defaults to enabling CGO if the GOOS/GOARCH build target is the same as the current platform, and CGO is supported on that platform. This means some users were Go builds of Caddy implicitly enabling CGO which would fail due to us previously having an indirect dependency on DataDog/zstd. That dependency is now gone since #4307, so we should no longer have any build issues _when enabling CGO_ if we don't have any dependencies which may optionally use CGO.
francislavoie
added a commit
that referenced
this pull request
Aug 25, 2021
This reverts commit f6d5ec2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See smallstep/nosql#12 for context.
Followup to #4291, but this time CGO is gone for good*!
The important deps to upgrade here are
smallstep/certificatesandsmallstep/nosqlbut I noticedsmallstep/clifell behind so I upgraded that too, which upgraded the rest implicitly.* At least until another dep decides to introduce something CGO for whatever reason, but let's hope not 😂