Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade smallstep libs #4291

Merged
merged 1 commit into from
Aug 19, 2021
Merged

chore: Upgrade smallstep libs #4291

merged 1 commit into from
Aug 19, 2021

Conversation

francislavoie
Copy link
Member

@francislavoie francislavoie commented Aug 18, 2021

See smallstep/nosql#12 for context.

/cc @ThinkChaos regarding #3525 (comment)

There's a surprising amount of go.sum changes from this, but I don't think we need to worry about that. It's a side effect of Go not pruning the graph in Go 1.16, I think once we bump to Go 1.17, it should get shrunken down significantly. See https://golang.org/ref/mod#graph-pruning

@francislavoie francislavoie added the under review 🧐 Review is pending before merging label Aug 18, 2021
@francislavoie francislavoie added this to the v2.4.4 milestone Aug 18, 2021
@francislavoie francislavoie requested a review from mholt August 18, 2021 20:04
@mholt
Copy link
Member

mholt commented Aug 19, 2021

So to be sure I follow, this removes the pb.proto warning and removes the cgo dependency?

@francislavoie
Copy link
Member Author

Doesn't remove the CGO dependency yet. That's gonna require dgraph-io/badger#1736 first, because smallstep/nosql seems to not be able to safely upgrade to badger v3 without breaking changes, so I'm trying to get badger to backport the fix for that to their v2 branch.

But AFAIK yeah it should solve the pb.proto issue and some other random problems that have shown up since.

@ThinkChaos
Copy link

I can confirm it fixes the pb.proto warning for me.

@mholt mholt removed the under review 🧐 Review is pending before merging label Aug 19, 2021
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping push this along! Looking forward to getting rid of that cgo dependency too.

@mholt mholt merged commit a056fcd into master Aug 19, 2021
@mholt mholt deleted the upgrade-smallstep branch August 19, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants