feat(zstd): backport replacement of DataDog's zstd with Klauspost's zstd #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Aug 19, 2021
|
@danielmai Please take a look at this PR as well! Thanks! |
francislavoie
force-pushed
the
backport-zstd
branch
from
9b00587 to
397e234
Compare
dunglas
approved these changes
Aug 24, 2021
NamanJain8
approved these changes
Aug 25, 2021
|
Thank you @NamanJain8! Please tag a new v2 release at your earliest convenience! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the changes from #1706 and #1709 to the v2 branch of badger.
For context, https://github.com/caddyserver/caddy uses https://github.com/smallstep/certificates which uses https://github.com/smallstep/nosql which uses badger.
See smallstep/nosql#12 for the discussion. It's not currently viable for smallstep to upgrade from v2 to v3 of badger, so it would be nice to backport this zstd change to the v2 branch to remove the implicit (yet optional) CGO dependency on Caddy.
I targeted the
release/v2.2007branch, I couldn't really see a more relevant branch to target, so I hope that's okay.This change is