feat(compression): use klauspost zstd when cgo is not enabled #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
force-pushed
the
naman/klauspost-zstd
branch
from
55ee6cd to
1ec0af3
Compare
jarifibrahim
approved these changes
May 26, 2021
There was a problem hiding this comment.
Awesome @NamanJain8 ! Let's merge this once the build goes through.
Also, please run all the tests locally with CGO_ENABLED=0 . The tests currently run with CGO enabled.
@danielmai can we check why the CI is not running on these PRs?
Done. All tests passed locally. |
This was referenced May 28, 2021
NamanJain8
added a commit
that referenced
this pull request
Jul 2, 2021
Use https://github.com/klauspost/compress ZSTD compression when CGO is not enabled. Related to #1383 (cherry picked from commit b188600)
NamanJain8
pushed a commit
that referenced
this pull request
Aug 25, 2021
…std (#1736) Backports the changes from #1706 and #1709 to the v2 branch of badger. For context, https://github.com/caddyserver/caddy uses https://github.com/smallstep/certificates which uses https://github.com/smallstep/nosql which uses badger. See smallstep/nosql#12 for the discussion. It's not currently viable for smallstep to upgrade from v2 to v3 of badger, so it would be nice to backport this zstd change to the v2 branch to remove the implicit (yet optional) CGO dependency on Caddy. I targeted the release/v2.2007 branch, I couldn't really see a more relevant branch to target, so I hope that's okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use https://github.com/klauspost/compress ZSTD compression when CGO is not enabled.
Related to #1383
This change is