Backport "Fix build on Plan 9" to Badger v2 #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <fshahriar@gmail.com>
|
|
manishrjain
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @francislavoie)
What's needed from me? P.S. Please don't forget about #1736 as well! |
|
Thanks for the PR @francislavoie. I'll merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1451 (comment) for context.
The fixes for Plan 9 were merged to the v3 branch, but it would be useful to have on the v2 branch as well, so we can get a step closer to Caddy working on Plan 9 caddyserver/caddy#3615
This change is