Move public proto IDLs from cadence server #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytautas-karpavicius
force-pushed
the
proto
branch
3 times, most recently
from
bbca013
to
63a2554
Compare
vytautas-karpavicius
force-pushed
the
proto
branch
from
63a2554
to
ee1aded
Compare
vytautas-karpavicius
force-pushed
the
proto
branch
from
ee1aded
to
bdf75cf
Compare
mantas-sidlauskas
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves public part of proto IDLs within cadence server. So that they could soon be shared with cadence clients.
It also creates Makefile with
proto-lintrule to check proto files withbuflinter. This linter is also trigerred within buildkite as one of the PR checks.Note: we may need to address current
go_packagedefined in proto files, as it may not fit go client. But for now leaving the move purely mechanical.