Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved out public proto IDLs to cadence-idls repository #4152

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented Apr 21, 2021

What changed?
This is sibling PR for cadence-workflow/cadence-idl#64 - public proto IDLs were moved to cadence-idls repository.
Here we remove public proto files, update idls submodule and create a symlink from previous public folder to point to idls submodule.

Why?
To reuse proto IDLs within Cadence clients.

How did you test it?
Regenerated proto files

rm .build/protoc
make .build/protoc
make fmt

Potential risks
Proto generation may be broken.

Release notes

Documentation Changes

@@ -209,7 +209,7 @@ $(THRIFT_GEN): $(THRIFT_FILES) $(BIN)/thriftrw $(BIN)/thriftrw-plugin-yarpc | $(
PROTO_ROOT := proto
# output location is defined by `option go_package` in the proto files, all must stay in sync with this
PROTO_OUT := .gen/proto
PROTO_FILES = $(shell find ./$(PROTO_ROOT) -name "*.proto" | grep -v "persistenceblobs")
PROTO_FILES = $(shell find -L ./$(PROTO_ROOT) -name "*.proto" | grep -v "persistenceblobs")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-L to follow symlinks

@vytautas-karpavicius vytautas-karpavicius requested a review from a team April 21, 2021 14:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 63162965-d851-49f8-a8a4-843892914d04

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 57 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.03%) to 59.702%

Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 44.78%
client/history/metricClient.go 2 49.43%
common/task/fifoTaskScheduler.go 2 84.54%
service/history/execution/mutable_state_builder.go 2 69.85%
service/history/handler.go 2 46.59%
service/history/queue/transfer_queue_processor.go 2 57.37%
service/history/task/transfer_standby_task_executor.go 2 90.77%
service/matching/taskListManager.go 2 74.72%
service/frontend/workflowHandler.go 4 56.72%
service/history/execution/context.go 6 65.64%
Totals Coverage Status
Change from base Build 45e2b378-e3a5-4aac-aa26-589b3ee57b09: -0.03%
Covered Lines: 87655
Relevant Lines: 146822

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review April 21, 2021 14:21
@vytautas-karpavicius vytautas-karpavicius merged commit 30702c2 into cadence-workflow:master Apr 21, 2021
@vytautas-karpavicius vytautas-karpavicius deleted the move-public-proto branch April 21, 2021 14:35
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants