Update SQL task manager to support sharded SQL DB (#4171)

cadence-workflow · Apr 30, 2021 · 4a71b12 · 4a71b12
1 parent fd38229
commit 4a71b12
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/common/persistence/sql/sqlTaskManager.go b/common/persistence/sql/sqlTaskManager.go
@@ -401,6 +401,7 @@ func (m *sqlTaskManager) CreateTasks(
 			return nil, err
 		}
 		currTasksRow := sqlplugin.TasksRow{
+			ShardID:      m.shardID(v.Data.DomainID, request.TaskListInfo.Name),
 			DomainID:     serialization.MustParseUUID(v.Data.DomainID),
 			TaskListName: request.TaskListInfo.Name,
 			TaskType:     int64(request.TaskListInfo.TaskType),
@@ -453,6 +454,7 @@ func (m *sqlTaskManager) GetTasks(
 	request *persistence.GetTasksRequest,
 ) (*persistence.InternalGetTasksResponse, error) {
 	rows, err := m.db.SelectFromTasks(ctx, &sqlplugin.TasksFilter{
+		ShardID:      m.shardID(request.DomainID, request.TaskList),
 		DomainID:     serialization.MustParseUUID(request.DomainID),
 		TaskListName: request.TaskList,
 		TaskType:     int64(request.TaskType),
@@ -493,6 +495,7 @@ func (m *sqlTaskManager) CompleteTask(
 	taskID := request.TaskID
 	taskList := request.TaskList
 	_, err := m.db.DeleteFromTasks(ctx, &sqlplugin.TasksFilter{
+		ShardID:      m.shardID(taskList.DomainID, taskList.Name),
 		DomainID:     serialization.MustParseUUID(taskList.DomainID),
 		TaskListName: taskList.Name,
 		TaskType:     int64(taskList.TaskType),
@@ -508,6 +511,7 @@ func (m *sqlTaskManager) CompleteTasksLessThan(
 	request *persistence.CompleteTasksLessThanRequest,
 ) (int, error) {
 	result, err := m.db.DeleteFromTasks(ctx, &sqlplugin.TasksFilter{
+		ShardID:              m.shardID(request.DomainID, request.TaskListName),
 		DomainID:             serialization.MustParseUUID(request.DomainID),
 		TaskListName:         request.TaskListName,
 		TaskType:             int64(request.TaskType),

diff --git a/common/persistence/sql/sqlplugin/interfaces.go b/common/persistence/sql/sqlplugin/interfaces.go
@@ -170,6 +170,7 @@ type (
 
 	// TasksRow represents a row in tasks table
 	TasksRow struct {
+		ShardID      int
 		DomainID     serialization.UUID
 		TaskType     int64
 		TaskID       int64
@@ -198,6 +199,7 @@ type (
 	// TasksFilter contains the column names within tasks table that
 	// can be used to filter results through a WHERE clause
 	TasksFilter struct {
+		ShardID              int
 		DomainID             serialization.UUID
 		TaskListName         string
 		TaskType             int64