Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQL task manager to support sharded SQL DB #4171

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

Shaddoll
Copy link
Member

What changed?
Update sql task manager to set shard ID for task and pass it down to sql plugins

Why?
When creating new tasks, we need to perform transactions across tasks and task_lists table.
In sharded SQL case, we need a shard id to ensure the transaction is within a shard.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build a36a31ff-d3ff-43fe-afe5-92ed5739ec47

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.007%) to 59.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/sql/sqlTaskManager.go 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
host/archivalTest.go 1 97.81%
host/signalworkflowTest.go 1 95.53%
common/persistence/historyStore.go 2 66.41%
common/types/mapper/thrift/shared.go 2 71.12%
service/matching/taskListManager.go 2 74.72%
common/task/fifoTaskScheduler.go 3 84.54%
common/persistence/cassandra/cassandraPersistenceUtil.go 12 92.05%
Totals Coverage Status
Change from base Build dc576523-957d-4d63-b0f9-ef111290e3e1: 0.007%
Covered Lines: 87927
Relevant Lines: 147093

💛 - Coveralls

@Shaddoll Shaddoll merged commit 416f7c5 into cadence-workflow:master Apr 30, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants