Fix warnings when compiling the source code (#4036)

**What changed?**

Fix some warnings when `make bins`

**Why?**

The suggestion was reasonable, so we should fix it as we can

**How did you test it?**

* `make bins` to check whether those warnings were disappeared or not 
* make test

**Potential risks**

no

common/domain/replication_queue.go

@@ -229,16 +229,11 @@ func (q *replicationQueueImpl) UpdateDLQAckLevel(
 	ctx context.Context,
 	lastProcessedMessageID int64,
 ) error {
-
-	if err := q.queue.UpdateDLQAckLevel(
+	return q.queue.UpdateDLQAckLevel(
 		ctx,
 		lastProcessedMessageID,
 		localDomainReplicationCluster,
-	); err != nil {
-		return err
-	}
-
-	return nil
+	)
 }
 
 func (q *replicationQueueImpl) GetDLQAckLevel(
@@ -261,16 +256,11 @@ func (q *replicationQueueImpl) RangeDeleteMessagesFromDLQ(
 	firstMessageID int64,
 	lastMessageID int64,
 ) error {
-
-	if err := q.queue.RangeDeleteMessagesFromDLQ(
+	return q.queue.RangeDeleteMessagesFromDLQ(
 		ctx,
 		firstMessageID,
 		lastMessageID,
-	); err != nil {
-		return err
-	}
-
-	return nil
+	)
 }
 
 func (q *replicationQueueImpl) DeleteMessageFromDLQ(

common/persistence/nosql/nosqlplugin/cassandra/domain.go

@@ -565,9 +565,5 @@ func (db *cdb) deleteDomain(
 	}
 
 	query = db.session.Query(templateDeleteDomainQuery, ID).WithContext(ctx)
-	if err := query.Exec(); err != nil {
-		return err
-	}
-
-	return nil
+	return query.Exec()
 }

common/service/config/config.go

@@ -429,10 +429,7 @@ func (c *Config) ValidateAndFillDefaults() error {
 	if err := c.validate(); err != nil {
 		return err
 	}
-	if err := c.fillDefaults(); err != nil {
-		return err
-	}
-	return nil
+	return c.fillDefaults()
 }
 
 func (c *Config) validate() error {

service/history/task/transfer_active_task_executor.go

@@ -901,7 +901,7 @@ func (t *transferActiveTaskExecutor) processResetWorkflow(
 	// reset workflow needs to go through the history so it may take a long time.
 	// as a result it's not subject to the taskDefaultTimeout. Otherwise the task
 	// may got stuck if the workflow history is large.
-	if err := t.resetWorkflow(
+	return t.resetWorkflow(
 		task,
 		domainEntry.GetInfo().Name,
 		reason,
@@ -911,10 +911,7 @@ func (t *transferActiveTaskExecutor) processResetWorkflow(
 		currentContext,
 		currentMutableState,
 		logger,
-	); err != nil {
-		return err
-	}
-	return nil
+	)
 }
 
 func (t *transferActiveTaskExecutor) recordChildExecutionStarted(

service/worker/batcher/workflow.go

@@ -40,8 +40,12 @@ import (
 	"github.com/uber/cadence/common/types"
 )
 
+type (
+	contextKey string
+)
+
 const (
-	batcherContextKey = "batcherContext"
+	batcherContextKey contextKey = "batcherContext"
 	// BatcherTaskListName is the tasklist name
 	BatcherTaskListName = "cadence-sys-batcher-tasklist"
 	// BatchWFTypeName is the workflow type

service/worker/failovermanager/workflow.go

@@ -36,8 +36,12 @@ import (
 	"github.com/uber/cadence/common/types"
 )
 
+type (
+	contextKey string
+)
+
 const (
-	failoverManagerContextKey = "failoverManagerContext"
+	failoverManagerContextKey contextKey = "failoverManagerContext"
 	// TaskListName tasklist
 	TaskListName = "cadence-sys-failoverManager-tasklist"
 	// WorkflowTypeName workflow type name

service/worker/parentclosepolicy/workflow.go

@@ -34,8 +34,12 @@ import (
 	"github.com/uber/cadence/common/types"
 )
 
+type (
+	contextKey string
+)
+
 const (
-	processorContextKey = "processorContext"
+	processorContextKey contextKey = "processorContext"
 	// processorTaskListName is the tasklist name
 	processorTaskListName = "cadence-sys-processor-parent-close-policy"
 	// processorWFTypeName is the workflow type