Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings when compiling the source code #4036

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Fix warnings when compiling the source code #4036

merged 2 commits into from
Mar 9, 2021

Conversation

git-hulk
Copy link
Contributor

@git-hulk git-hulk commented Mar 4, 2021

What changed?

Fix some warnings when make bins

Why?

The suggestion was reasonable, so we should fix it as we can

How did you test it?

  • make bins to check whether those warnings were disappeared or not
  • make test

Potential risks

no

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yycptt yycptt requested review from mantas-sidlauskas and a team March 5, 2021 19:42
Groxx
Groxx requested changes Mar 6, 2021
View reviewed changes
Copy link
Member

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context-key-types should change, but the err-returns look good. and thank you!

service/worker/scanner/scanner.go Outdated Show resolved Hide resolved
common/constants.go Outdated Show resolved Hide resolved
@git-hulk git-hulk requested a review from Groxx March 7, 2021 02:28
@Groxx
Copy link
Member

Groxx commented Mar 8, 2021

Well that's not a very clear error :\

INFO  Event name: pull_request
INFO  Updating PR #4036 Fix warnings when compiling the source code
INFO  fix-warning-when-building HEAD: 4b7d7f27df2e7c49324ad2a14fccc2805241ef0f
INFO  Rebasing onto master f2f10d4dbb4cad55b3444ea9dff1bae81008e4bb
ERROR command failed with code 128: git push --quiet --force-with-lease origin fix-warning-when-building

mind merging master / rebasing? I wonder if something is conflicting.

@git-hulk
Copy link
Contributor Author

git-hulk commented Mar 9, 2021 •
edited
Loading

@Groxx I have merged and rebased the master, it seems no conflict was found. : )

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 66.773% when pulling de9b6b6 on git-hulk:fix-warning-when-building into 1b3436c on uber:master.

Groxx
Groxx approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and all the changes!

@Groxx Groxx merged commit d7efde4 into cadence-workflow:master Mar 9, 2021
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
@git-hulk @yux0
Fix warnings when compiling the source code (cadence-workflow#4036)
d1a1a3e 
**What changed?**

Fix some warnings when `make bins`

**Why?**

The suggestion was reasonable, so we should fix it as we can

**How did you test it?**

* `make bins` to check whether those warnings were disappeared or not 
* make test

**Potential risks**

no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groxx Groxx Groxx approved these changes

@mantas-sidlauskas mantas-sidlauskas Awaiting requested review from mantas-sidlauskas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@git-hulk @CLAassistant @Groxx @coveralls