Range query for custom attribute #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not visibility triple manager
bowenxia
commented
Oct 19, 2023
| @@ -185,7 +185,7 @@ LIMIT 0, 10 | |||
| FROM %s | |||
| WHERE DomainID = 'bfd5c907-f899-4baf-a7b2-2ab85e623ebd' | |||
| AND IsDeleted = false | |||
| AND WorkflowID = 'wid' and ((JSON_MATCH(Attr, '"$.CustomStringField" is not null') AND REGEXP_LIKE(JSON_EXTRACT_SCALAR(Attr, '$.CustomStringField', 'string'), 'custom and custom2 or custom3 order by*')) or CustomIntField between 1 and 10) | |||
There was a problem hiding this comment.
previously we didn't find the range query was not working since we used the old pinot table which we had flatten attribute. So the range query "between and" worked.
bowenxia
changed the title
neil-xie
reviewed
Oct 20, 2023
bowenxia
changed the title
neil-xie
reviewed
Oct 20, 2023
neil-xie
reviewed
Nov 2, 2023
| validated: "(JSON_MATCH(Attr, '\"$.CustomDatetimeField\" is not null') AND CAST(JSON_EXTRACT_SCALAR(Attr, '$.CustomDatetimeField') AS BIGINT) >= 1697754674)", | ||
| }, | ||
| "Case15-3: system date attribute greater than or equal to": { | ||
| query: "StartTime >= 1697754674", |
There was a problem hiding this comment.
When user input a date string like StartTime > "2023-11-02T15:36:47", is this handled in the query validator?
There was a problem hiding this comment.
This is not handled here. But that will be converted to UnixMilli() in PiontVisibilityStore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added "between and" for custom attributes
Added <, >, <=, >= for custom attributes
Why?
Previously custom attributes only support equal operation
How did you test it?
unit test
Integration test
Potential risks
Release notes
Documentation Changes