Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range query for custom attribute #5426

Merged
merged 97 commits into from
Nov 3, 2023
Merged

Range query for custom attribute #5426

merged 97 commits into from
Nov 3, 2023

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    f771131 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b86598 View commit details
    Browse the repository at this point in the history
  3. update: go mod tidy

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    360ee20 View commit details
    Browse the repository at this point in the history
  4. update go.sum

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3f074de View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    218e829 View commit details
    Browse the repository at this point in the history
  6. update unit test

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    fa587cb View commit details
    Browse the repository at this point in the history
  7. run make cmds to update files

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    bb4fa67 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c056a9f View commit details
    Browse the repository at this point in the history
  9. fix unit test

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    10b4598 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7421c35 View commit details
    Browse the repository at this point in the history
  11. add ES into docker compose file

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    931f364 View commit details
    Browse the repository at this point in the history
  12. Fix kafka producer message

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    624a769 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    9130637 View commit details
    Browse the repository at this point in the history
  14. cleanup

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    909ac6f View commit details
    Browse the repository at this point in the history
  15. change tableName and places used it accordingly, to allow pinot to re…

    …cognize the name
    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d623f8f View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    8ac32e8 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    2370332 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    94cb588 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ed103a5 View commit details
    Browse the repository at this point in the history
  20. change PinotClient to be public

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ab15272 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    d749c1a View commit details
    Browse the repository at this point in the history
  22. Fix the log format

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6191af5 View commit details
    Browse the repository at this point in the history
  23. update kafka config to separate kafka topics for pinot and ES, add pi…

    …not visibility triple manager
    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9f7b620 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    8aade6a View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    52e993d View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    97b5763 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    a3c05cc View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    3ff2029 View commit details
    Browse the repository at this point in the history
  29. add attr into pinot

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ba1879d View commit details
    Browse the repository at this point in the history
  30. update decoded attr

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6c3dd9c View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    45ccf60 View commit details
    Browse the repository at this point in the history
  32. add single quote to query

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dc93318 View commit details
    Browse the repository at this point in the history
  33. correct order Query formations

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c71355d View commit details
    Browse the repository at this point in the history
  34. Add log for debug purpose

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b73ad5f View commit details
    Browse the repository at this point in the history
  35. fix can't unmarshal request.Attr error

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0b1d5a2 View commit details
    Browse the repository at this point in the history
  36. fix nil pointer in isRecordValid

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9407591 View commit details
    Browse the repository at this point in the history
  37. clean up

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    067e71c View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    31cbb5b View commit details
    Browse the repository at this point in the history
  39. solve can't unmarshal attr issue

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    64ff7bb View commit details
    Browse the repository at this point in the history
  40. update unit test to pass

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    66db061 View commit details
    Browse the repository at this point in the history
  41. Get pinot table from config

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8f7dcaf View commit details
    Browse the repository at this point in the history
  42. Update table name in config

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    543810b View commit details
    Browse the repository at this point in the history
  43. use table name from config

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c95251c View commit details
    Browse the repository at this point in the history
  44. clean up

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d1fbe11 View commit details
    Browse the repository at this point in the history
  45. update unit test

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2fa02a3 View commit details
    Browse the repository at this point in the history
  46. change couple types in pinot message

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    376251d View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    9fda9f3 View commit details
    Browse the repository at this point in the history
  48. Cdnc 4574 (#5230)

    * update pinot config to enable text_index so that we could use Text_match function in query
    
    * implement customized attribute search
    
    * delete an unused function
    
    * change name to avoid build fail
    
    * use reg exp to split with case insensitive 'and'
    
    * clean up comment
    
    * clean up
    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c0c327c View commit details
    Browse the repository at this point in the history
  49. Add pagination and flatten customized search attributes (#5234)

    * implement pagination
    
    * add a test case for nextPageToken
    
    * add more test cases for pagination
    
    * change elastic search token into pinot token
    
    * clean up
    
    * fix count didn'w work issue
    
    * try to implement flatten schema, add attributes into schema
    
    * add attributes into schema
    
    * add some code to convert time to unix time in customized search attributes
    
    * refactor previously added code to a function
    
    * customized search attributes and unit tests
    
    * Remove attr column and minor clean up
    
    * edge case for ORDER BY in customized search attribute
    
    * Fix typo in name
    
    * add one more condition for parseLastElement
    
    * split one element of customized search attribute by operator instead of space; add a filter for customized attributes prefix
    
    * update unit test
    
    * update unit test
    
    ---------
    
    Co-authored-by: Neil Xie <neil.xie@uber.com>
    bowenxia and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    64748d6 View commit details
    Browse the repository at this point in the history
  50. Adds Dynamic-config type (#5261)

    - Refactors the config-store library to include a new dimension called 'configType' which allows for multiple stores.
    - Refactors the config-store slightly to reflect the fact that it is indeed actually a daemon
    
    These changes are tested and part of a larger set of changes of the 'zonal-isolation' feature
    davidporter-id-au authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5751cd1 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    3978502 View commit details
    Browse the repository at this point in the history
  52. update config file for deleting Attr

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    7ade724 View commit details
    Browse the repository at this point in the history
  53. fix a nil pointer after removing Attr

    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5a2c271 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    378597b View commit details
    Browse the repository at this point in the history
  55. Fix fmt

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6bc3f61 View commit details
    Browse the repository at this point in the history
  56. Add pinot integration test (#5316)

    * Add integration test for pinot and fix bugs
    
    * Fix frontend to read from pinot when set up pinot test cluster
    
    * Add a new map for Attr in response
    
    ---------
    
    Co-authored-by: Bowen Xiao <xbowen@uber.com>
    neil-xie and bowenxia committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f5b7734 View commit details
    Browse the repository at this point in the history
  57. Cdnc 4589 (#5318)

    * Add pinot dual visibility manager and new advance visibility option
    
    * update visibility store and implemented unit test
    
    * update: go mod tidy
    
    * update go.sum
    
    * Fix the start options for pinot
    
    * update unit test
    
    * run make cmds to update files
    
    * update one unit test case that had errors
    
    * fix unit test
    
    * Fix pinot config file and add ES config to make it run with workers and frontend
    
    * add ES into docker compose file
    
    * Fix kafka producer message
    
    * revert kafka change, update producer message struct to match with schema
    
    * cleanup
    
    * change tableName and places used it accordingly, to allow pinot to recognize the name
    
    * add a pinotClientInterface, refactor unit test
    
    * NewPinotConnectionClient should return a genetic value
    
    * fix a failed unit test & add mock genericClient component
    
    * rename pinotConnectionClient tobe pinotClient
    
    * change PinotClient to be public
    
    * Update visibility manager to use the new pinot generic client
    
    * Fix the log format
    
    * update kafka config to separate kafka topics for pinot and ES, add pinot visibility triple manager
    
    * Fix typo in pinot table config
    
    * change json tags to start with upper case to match pinot schema
    
    * Fix run ID json tag and remove unused kafka key from schema
    
    * fix a naming issue that cause pinot can't receive CloseTime
    
    * change json tag so that closeStatus won't be ignored when it is 0
    
    * add attr into pinot
    
    * update decoded attr
    
    * Update reading from pinot dynamic config
    
    * add single quote to query
    
    * correct order Query formations
    
    * Add log for debug purpose
    
    * fix can't unmarshal request.Attr error
    
    * fix nil pointer in isRecordValid
    
    * clean up
    
    * Remove unnecessary debug info and unused message fields
    
    * solve can't unmarshal attr issue
    
    * update unit test to pass
    
    * Get pinot table from config
    
    * Update table name in config
    
    * use table name from config
    
    * clean up
    
    * update unit test
    
    * change couple types in pinot message
    
    * update pinot visibility triple manager to write to pinot and ES (#5229)
    
    * Cdnc 4574 (#5230)
    
    * update pinot config to enable text_index so that we could use Text_match function in query
    
    * implement customized attribute search
    
    * delete an unused function
    
    * change name to avoid build fail
    
    * use reg exp to split with case insensitive 'and'
    
    * clean up comment
    
    * clean up
    
    * Add pagination and flatten customized search attributes (#5234)
    
    * implement pagination
    
    * add a test case for nextPageToken
    
    * add more test cases for pagination
    
    * change elastic search token into pinot token
    
    * clean up
    
    * fix count didn'w work issue
    
    * try to implement flatten schema, add attributes into schema
    
    * add attributes into schema
    
    * add some code to convert time to unix time in customized search attributes
    
    * refactor previously added code to a function
    
    * customized search attributes and unit tests
    
    * Remove attr column and minor clean up
    
    * edge case for ORDER BY in customized search attribute
    
    * Fix typo in name
    
    * add one more condition for parseLastElement
    
    * split one element of customized search attribute by operator instead of space; add a filter for customized attributes prefix
    
    * update unit test
    
    * update unit test
    
    ---------
    
    Co-authored-by: Neil Xie <neil.xie@uber.com>
    
    * Adds Dynamic-config type (#5261)
    
    - Refactors the config-store library to include a new dimension called 'configType' which allows for multiple stores.
    - Refactors the config-store slightly to reflect the fact that it is indeed actually a daemon
    
    These changes are tested and part of a larger set of changes of the 'zonal-isolation' feature
    
    * clean up: delete one unused function, and one line refactor
    
    * update config file for deleting Attr
    
    * fix a nil pointer after removing Attr
    
    * update a test case to cover multiple order by clause case
    
    * Fix fmt
    
    * Add integration test for pinot
    
    * Fix frontend to read from pinot when set up pinot test cluster
    
    * Update history to load pinot config correctly
    
    * add more test cases/most of them are failing
    
    * fix WorkflowExecutionCloseStatus unmarshal panic
    
    * add a new map for Attr in response
    
    * pass upsert tests
    
    * scanWorkflow pass
    
    * pass listOpenWorkflow
    
    * pass pagination tests
    
    * all test passed
    
    * BinaryChecksums support arrays
    
    * make go-generate && make fmt && make lint && make copyright
    
    * Minor tweaks
    
    * Clean up
    
    * handle CloseTime = missing case
    
    * only deal with system keys
    
    * delete single quote for search val if it is not string
    
    * cleanup
    
    * refactor utility functions to a new file for both OSS and Mono repo to use
    
    * run make go-generate && make fmt && make lint && make copyright
    
    ---------
    
    Co-authored-by: Neil Xie <neil.xie@uber.com>
    Co-authored-by: neil-xie <104041627+neil-xie@users.noreply.github.com>
    Co-authored-by: David Porter <david.porter@uber.com>
    4 people committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    bac8352 View commit details
    Browse the repository at this point in the history
  58. Update Pinot query to order by closetime when query closed wf, order …

    …by runID when query open wf
    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    97bc5a4 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    af28635 View commit details
    Browse the repository at this point in the history
  60. Revert "refactor pinotClient to pass in pinotConfig"

    This reverts commit 4f403b2.
    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0d527a9 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    16c37ea View commit details
    Browse the repository at this point in the history
  62. PinotQueryValidator (#5333)

    * add pinotQueryValidator, and change default order by to be StartTime
    
    * clean up: delete comments
    
    * clean up: run make copy right things
    
    * refactor PinotQueryValidator
    
    * refactor
    
    * clean up: run copyright things
    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3bb3010 View commit details
    Browse the repository at this point in the history
  63. Add limit clause to pinot queries (#5337)

    * add limit clause to queries
    
    * cleanup: run make copyright things
    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    76247ac View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    79c83e5 View commit details
    Browse the repository at this point in the history
  65. Adding a PInot/ES response comparator (#5353)

    * add response comparator
    
    *when comparison fails, it will return es result and log the error
    
    * if can't start both mgr, use only one mgr
    
    * Refactor code to determine read mode and which visibility manager to use when read mode is both
    
    * Return valid response when one of the source is broken
    
    ---------
    
    Co-authored-by: Neil Xie <neil.xie@uber.com>
    bowenxia and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b695a18 View commit details
    Browse the repository at this point in the history
  66. Fix rebase and lint

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    763e378 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    fa08342 View commit details
    Browse the repository at this point in the history
  68. more clean up

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2db04d3 View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    9afb738 View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    1adf907 View commit details
    Browse the repository at this point in the history
  71. Enable json index (#5390)

    * enable json index, change the quries for exact/partial match, update the unit tests
    
    * make it pass integration test: found that order by is not supported in json index column
    
    * update partial match query. It didn't work in the mono repo
    
    * Implemented deletion method for Pinot visibility store (#5404)
    bowenxia authored and neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    91adba5 View commit details
    Browse the repository at this point in the history
  72. Rebase

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3d1ac46 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    8d9da02 View commit details
    Browse the repository at this point in the history
  74. More clean up

    neil-xie committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    fca6bba View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. turn off comparator

    bowenxia committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    ac9c769 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Add pinot metrics client and update pinot visibility manager to use it (

    #5411)
    
    * Add pinot metrics client and update pinot visibility manager to use it
    neil-xie authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    eae9ad4 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    c49ea32 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Configuration menu
    Copy the full SHA
    775a31e View commit details
    Browse the repository at this point in the history
  2. Address comments part 1

    neil-xie committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b4e2c66 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    295a989 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    7b68dd3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed8dbe2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    02a0812 View commit details
    Browse the repository at this point in the history
  4. Fix

    neil-xie committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    593483b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Minor fix for stopwatch

    neil-xie committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2cbfa21 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c84916 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Add more comments

    neil-xie committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    cce115e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6917e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b98b5b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    45031c5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    21d1dda View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0d2f41a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    49fe217 View commit details
    Browse the repository at this point in the history
  8. remove dead code

    bowenxia committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    41a8345 View commit details
    Browse the repository at this point in the history
  9. add unit tests

    bowenxia committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    94c308e View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Configuration menu
    Copy the full SHA
    2bf6418 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    5e3bc5c View commit details
    Browse the repository at this point in the history