Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made execution.Cache an interface so we can mock it in unit tests #6058

Merged
merged 2 commits into from
May 24, 2024

Made execution cache an interface, that way we can mock it in unit tests

36d7881
Select commit
Loading
Failed to load commit list.
Merged

Made execution.Cache an interface so we can mock it in unit tests #6058

Made execution cache an interface, that way we can mock it in unit tests
36d7881
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 24, 2024 in 0s

67.85% (target 85.00%)

View this Pull Request on Codecov

67.85% (target 85.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.85%. Comparing base (fc6fae5) to head (36d7881).
Report is 4 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
service/history/decision/handler.go 94.93% <ø> (ø)
...ervice/history/engine/engineimpl/history_engine.go 83.67% <ø> (ø)
service/history/execution/cache.go 37.24% <100.00%> (ø)
service/history/ndc/activity_replicator.go 85.36% <ø> (ø)
service/history/ndc/history_replicator.go 17.13% <ø> (ø)
service/history/ndc/transaction_manager.go 72.81% <ø> (ø)
...ice/history/queue/cross_cluster_queue_processor.go 39.13% <ø> (ø)
...istory/queue/cross_cluster_queue_processor_base.go 45.99% <ø> (ø)
service/history/queue/factory.go 100.00% <ø> (ø)
service/history/queue/timer_queue_processor.go 24.57% <ø> (ø)
... and 12 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc6fae5...36d7881. Read the comment docs.