Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adapater functions for delayStart and jitterStart in child workflow #6201

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add adapater functions for delayStart and jitterStart in child workflow #6201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/types/mapper/thrift/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5212,6 +5212,8 @@ func FromStartChildWorkflowExecutionInitiatedEventAttributes(t *types.StartChild
Header: FromHeader(t.Header),
Memo: FromMemo(t.Memo),
SearchAttributes: FromSearchAttributes(t.SearchAttributes),
DelayStartSeconds: t.DelayStartSeconds,
JitterStartSeconds: t.JitterStartSeconds,
Comment on lines +5215 to +5216
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this.

FirstRunAtTimestamp: t.FirstRunAtTimestamp,
}
}
Expand All @@ -5238,6 +5240,8 @@ func ToStartChildWorkflowExecutionInitiatedEventAttributes(t *shared.StartChildW
Header: ToHeader(t.Header),
Memo: ToMemo(t.Memo),
SearchAttributes: ToSearchAttributes(t.SearchAttributes),
DelayStartSeconds: t.DelayStartSeconds,
JitterStartSeconds: t.JitterStartSeconds,
FirstRunAtTimestamp: t.FirstRunAtTimestamp,
}
}
Expand Down
2 changes: 2 additions & 0 deletions common/types/testdata/history.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,8 @@ var (
Header: &Header,
Memo: &Memo,
SearchAttributes: &SearchAttributes,
DelayStartSeconds: &Duration3,
JitterStartSeconds: &Duration4,
FirstRunAtTimestamp: &Timestamp1,
}
StartChildWorkflowExecutionFailedEventAttributes = types.StartChildWorkflowExecutionFailedEventAttributes{
Expand Down
Loading