Remove background_color and clear_frame
#108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves caemor#100 I did find one display which was using `background_color` for stuff other than `clear_frame` - the epd5in16f was using it to set the border color. For now, I've replaced it with a `set_border_color` method which is only on that display. It should eventually be replaced by a proper method on `WaveshareDisplay`, but I don't have any hardware which supports border colors that I can test with.
Liamolucko
force-pushed
the
no-background-color
branch
from
9316024
to
fe58fc5
Compare
caemor
reviewed
Jun 2, 2022
| &mut spi, | ||
| &[Color::White.get_byte_value(); BUFFER_LEN], | ||
| &mut delay, | ||
| )?; |
There was a problem hiding this comment.
I think by removing the clear frame command this got even easier to understand 👍
| @@ -249,27 +246,6 @@ where | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn clear_frame(&mut self, spi: &mut SPI, _delay: &mut DELAY) -> Result<(), SPI::Error> { | |||
There was a problem hiding this comment.
Since we aren't able to test all the devices it might be better to just add the color parameter since it might be useful as a helper function.
|
Sorry for the late response I just realized that I never had published my review and it was still pending 🙈 |
|
I think we should just keep the clear_frame method, it is useful for initializing and testing the epd, especially when compiled without the graphic feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #100
Removes
background_color,set_background_color, andclear_frame, and properly handles the filling of the chromatic layer when rendering in black and white.Looking back at #100, I'm not entirely clear if you wanted to keep or remove
clear_frame; I'm happy to put it back taking the color to clear with as an argument.I did find one display which was using
background_colorfor stuff other thanclear_frame- the epd5in16f was using it to set the border color. For now, I've replaced it with aset_border_colormethod which is only on that display. It should eventually be replaced by a proper method onWaveshareDisplay, but I don't have any hardware which supports border colors that I can test with.