Remove background color but not clear_frame #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caemor
requested changes
Dec 7, 2022
Comment on lines
+204
to
+205
| TriColor::Black => (0x00, 00), | ||
| TriColor::Chromatic => (0xFF, 00), |
There was a problem hiding this comment.
Suggested change
| TriColor::Black => (0x00, 00), | |
| TriColor::Chromatic => (0xFF, 00), | |
| TriColor::Black => (0x00, 0x00), | |
| TriColor::Chromatic => (0xFF, 0x00), |
| @@ -23,6 +23,8 @@ use self::command::Command; | |||
| use crate::buffer_len; | |||
|
|
|||
| /// Full size buffer for use with the 7in5 v3 EPD | |||
| // Note v2 is bicolor, cannot find v3 on the website | |||
| // 7in5B v3 exists and is tricolor, but it doesn't work wit this driver | |||
There was a problem hiding this comment.
I believe it was b v3 (https://www.waveshare.com/wiki/7.5inch_e-Paper_HAT_(B)_Manual#Introduction) (#26 (comment)). It was based of marcelbuesings original work for the 7in5bc and I though he got it working. Did you test it?
The module should be renamed to epd7in5b_v3 anyway
EDIT: I think we might be able to just delete it, since your old pr already added support for v2 and v3 for the 7in5b variant.
Liamolucko
reviewed
Dec 7, 2022
Comment on lines
-281
to
+274
| let color = DEFAULT_BACKGROUND_COLOR.get_byte_value(); | ||
| let color = color.get_byte_value(); |
There was a problem hiding this comment.
This shouldn't be used for both the black and white layer and the chromatic layer - since we're only clearing to black or white, the chromatic layer should always be left as white.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for @Liamolucko
I could not start from #108 it was too much work to re-add clear_frame