Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug when setting process environment variable #1693

Closed
patriksvensson opened this issue Jul 24, 2017 · 1 comment · Fixed by #1717
Closed

Possible bug when setting process environment variable #1693

patriksvensson opened this issue Jul 24, 2017 · 1 comment · Fixed by #1717
Assignees
@devlead
Labels
Bug
Milestone
v0.22.0

Comments

@patriksvensson
Copy link
Member

Was cleaning up Resharper warnings as part of a PR and noticed this: https://github.com/cake-build/cake/blob/develop/src/Cake.Core/Polyfill/ProcessHelper.cs#L20

We should figure out what is the intended behavior here, and if the current behavior is correct, remove envKey.
@devlead
Copy link
Member

devlead commented Jul 24, 2017

env key should be used if we want consistent xplat, otherwise it can be removed.

Thinking initial intent was to work around a casing issue with corrupt environment variables, which it didn't, but this could also be the reason it didn't 😁

@devlead devlead self-assigned this Aug 2, 2017
@devlead devlead added this to the v0.22.0 milestone Aug 2, 2017
devlead added a commit to devlead/cake that referenced this issue Aug 2, 2017
@devlead
(cake-buildGH-1693) Fix key not used when setting process environment…
83d8032 
… variable

* fixes cake-build#1693
@devlead devlead mentioned this issue Aug 2, 2017
Merged
gep13 added a commit that referenced this issue Aug 2, 2017
@gep13
Merge pull request #1717 from devlead/feature/GH-1693
93ca222 
GH1693: Fix key not used when setting process environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devlead devlead

Labels
Bug
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging a pull request may close this issue.

GH1693: Fix key not used when setting process environment variable devlead/cake
2 participants
@patriksvensson @devlead