Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Roslyn to 3.6.0 #2778

Closed
devlead opened this issue May 19, 2020 · 3 comments · Fixed by #2779 or #2780
Closed

Update Roslyn to 3.6.0 #2778

devlead opened this issue May 19, 2020 · 3 comments · Fixed by #2779 or #2780
Assignees
@devlead
Labels
Improvement
Milestone
v0.38.0

Comments

@devlead
Copy link
Member

devlead commented May 19, 2020

Currently, we use a beta version 3.6.0 in now released.

cake/src/Cake/Cake.csproj

Line 30 in 0bed030

<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Scripting" Version="3.5.0-beta2-final" />

@devlead devlead added this to the v0.38.0 milestone May 19, 2020
@devlead devlead self-assigned this May 19, 2020
@gitfool
Copy link
Contributor

gitfool commented May 20, 2020

How about bumping all dependencies to latest stable versions? Easy with dotnet-outdated:

Cake/src on  develop via •NET v3.1.300
❯ dotnet outdated -pre=never
» Cake.NuGet
  [.NETFramework,Version=v4.6.1]
  Microsoft.DotNet.PlatformAbstractions  3.1.0         -> 3.1.4
  Newtonsoft.Json                        12.0.2        -> 12.0.3
  NuGet.Common                           5.4.0         -> 5.5.1
  NuGet.Frameworks                       5.4.0         -> 5.5.1
  NuGet.Packaging                        5.4.0         -> 5.5.1
  NuGet.Protocol                         5.4.0         -> 5.5.1
  NuGet.Resolver                         5.4.0         -> 5.5.1
  NuGet.Versioning                       5.4.0         -> 5.5.1
  StyleCop.Analyzers                     1.1.0-beta004 -> 1.1.118
  [.NETStandard,Version=v2.0]
  Microsoft.DotNet.PlatformAbstractions  3.1.0         -> 3.1.4
  Microsoft.NETCore.Platforms            3.1.0         -> 3.1.1
  Newtonsoft.Json                        12.0.2        -> 12.0.3
  NuGet.Common                           5.4.0         -> 5.5.1
  NuGet.Frameworks                       5.4.0         -> 5.5.1
  NuGet.Packaging                        5.4.0         -> 5.5.1
  NuGet.Protocol                         5.4.0         -> 5.5.1
  NuGet.Resolver                         5.4.0         -> 5.5.1
  NuGet.Versioning                       5.4.0         -> 5.5.1
  StyleCop.Analyzers                     1.1.0-beta004 -> 1.1.118

» Cake
  [.NETCoreApp,Version=v3.0]
  Autofac                                  4.9.4             -> 5.2.0
  Microsoft.CodeAnalysis.CSharp.Scripting  3.5.0-beta2-final -> 3.6.0
  StyleCop.Analyzers                       1.1.0-beta004     -> 1.1.118
  [.NETCoreApp,Version=v2.0]
  Autofac                                  4.9.4             -> 5.2.0
  Microsoft.CodeAnalysis.CSharp.Scripting  3.5.0-beta2-final -> 3.6.0
  StyleCop.Analyzers                       1.1.0-beta004     -> 1.1.118
  [.NETFramework,Version=v4.6.1]
  Autofac                                  4.9.4             -> 5.2.0
  Microsoft.CodeAnalysis.CSharp.Scripting  3.5.0-beta2-final -> 3.6.0
  StyleCop.Analyzers                       1.1.0-beta004     -> 1.1.118
  [.NETCoreApp,Version=v2.1]
  Autofac                                  4.9.4             -> 5.2.0
  Microsoft.CodeAnalysis.CSharp.Scripting  3.5.0-beta2-final -> 3.6.0
  StyleCop.Analyzers                       1.1.0-beta004     -> 1.1.118

» Cake.Tests
  [.NETCoreApp,Version=v3.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETCoreApp,Version=v2.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.3.0
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETFramework,Version=v4.6.1]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118

» Cake.Common.Tests
  [.NETCoreApp,Version=v3.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETCoreApp,Version=v2.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.3.0
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETFramework,Version=v4.6.1]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118

» Cake.Core.Tests
  [.NETCoreApp,Version=v3.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETCoreApp,Version=v2.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.3.0
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETFramework,Version=v4.6.1]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118

» Cake.Testing.Xunit
  [.NETFramework,Version=v4.6]
  StyleCop.Analyzers  1.1.0-beta004 -> 1.1.118
  [.NETStandard,Version=v2.0]
  StyleCop.Analyzers  1.1.0-beta004 -> 1.1.118

» Cake.Core
  [.NETStandard,Version=v2.0]
  Microsoft.CSharp          4.5.0         -> 4.7.0
  Microsoft.Win32.Registry  4.4.0         -> 4.7.0
  StyleCop.Analyzers        1.1.0-beta004 -> 1.1.118
  [.NETFramework,Version=v4.6]
  StyleCop.Analyzers  1.1.0-beta004 -> 1.1.118

» Cake.NuGet.Tests
  [.NETCoreApp,Version=v3.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETCoreApp,Version=v2.0]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.3.0
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118
  [.NETFramework,Version=v4.6.1]
  Castle.Core             4.2.1         -> 4.4.1
  Microsoft.NET.Test.Sdk  15.5.0        -> 16.6.1
  NSubstitute             3.1.0         -> 4.2.1
  StyleCop.Analyzers      1.1.0-beta004 -> 1.1.118

» Cake.Testing
  [.NETFramework,Version=v4.6]
  StyleCop.Analyzers  1.1.0-beta004 -> 1.1.118
  [.NETStandard,Version=v2.0]
  StyleCop.Analyzers  1.1.0-beta004 -> 1.1.118

» Cake.Common
  [.NETFramework,Version=v4.6]
  StyleCop.Analyzers  1.1.0-beta004 -> 1.1.118
  [.NETStandard,Version=v2.0]
  StyleCop.Analyzers  1.1.0-beta004 -> 1.1.118

Version color legend:
<red>   : Major version update or pre-release version. Possible breaking changes.
<yellow>: Minor version update. Backwards-compatible features added.
<green> : Patch version update. Backwards-compatible bug fixes.

You can upgrade packages to the latest version by passing the -u or -u:prompt option.
Elapsed: 00:00:03.7883609

@devlead
Copy link
Member Author

devlead commented May 20, 2020

In general, some are probably totally safe like StyleCop.Analyzers and test only related dependencies, but others like i.e. Newtonsoft.Json have caused significant issues downstream.

All should be updated but individually so we can test integration tests and clearly see which causes issues.

@gitfool gitfool mentioned this issue May 20, 2020
Merged
devlead added a commit to devlead/cake that referenced this issue May 20, 2020
@devlead
(cake-buildGH-2778) Update Roslyn to 3.6.0
a2aa35f 
* fixes cake-build#2778
@devlead devlead mentioned this issue May 20, 2020
Merged
@gitfool gitfool mentioned this issue May 20, 2020
Closed
patriksvensson added a commit that referenced this issue May 20, 2020
@patriksvensson
Merge pull request #2780 from devlead/feature/GH-2778
5bfe76a 
GH2778: Update Roslyn to 3.6.0
gep13 added a commit that referenced this issue May 30, 2020
@gep13
Merge branch 'release/0.38.0' into main
ea88e05 
* release/0.38.0: (48 commits)
  (build) Updated version and release notes.
  (GH-2658) Make BuildSystem.TFBuild obsolete
  (GH-2658) Update docs
  (GH-2658) Update unit tests
  (GH-2658) Fix stylecop error
  Add AzurePipelines alias. #2658
  (GH-2785) Add debug logs for when resolving tools
  Added NugetDelete function to Cake.Common.Tools.Nuget
  (doc) Add Enrico to author/copyright info
  (GH-2778) Update Roslyn to 3.6.0 * fixes #2778
  Bump .NET Core SDK to 3.1.300
  Diagnostic integration tests
  Add ANSI terminal support to log
  Added tests for Cake.Core.IO
  Revert GitVersion.Tool to 5.1.2
  Bump script dependencies
  (GH-2735) Improve documentation to make clear that project can be passed to MsBuild alias
  Skip-Option properly named: SkipOutputAnalysis.
  Added options to skip the analysis of the output file
  Add integration test for nuget setapikey
  ...
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v0.38.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@devlead devlead mentioned this issue Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devlead devlead

Labels
Improvement
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

GH2817: Bump dependencies gitfool/cake
GH2778: Update Roslyn to 3.6.0 devlead/cake
3 participants
@gitfool @devlead @cake-build-bot