-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH2817: Bump dependencies #2779
Conversation
Notes:
|
@devlead |
Running
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot going on in this one.
Could you start with the style cop upgrade and fixes in a separate issue and PR?
Sure. I'll suppress the StyleCop warnings in the first commit of this PR. |
@gitfool we
As we use issues for release notes and changelog, we would prefer dependency bump to be a bit more focused, so not about suppressing issues, but just have the work for style copy dependency upgrade and fixes in a separate issue and PR. |
Understood. I'll keep |
@gitfool your changes have been merged, thanks for your contribution 👍 |
@devlead the issue associated with this PR is marked as having been fixed in 0.38.0. Does that need to be updated? |
I will add a new issue, linked issue is for roslyn and already shipped. |
Fixes #2778.