Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH2817: Bump dependencies #2779

Merged
merged 1 commit into from
Jun 29, 2020
Merged

GH2817: Bump dependencies #2779

merged 1 commit into from
Jun 29, 2020

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented May 20, 2020

Fixes #2778.

@gitfool
Copy link
Contributor Author

gitfool commented May 20, 2020

Notes:

@gitfool
Copy link
Contributor Author

gitfool commented May 20, 2020

@devlead Azure Pipelines - Build Cake Windows failure is unrelated to my changes. Please retry.

@gitfool
Copy link
Contributor Author

gitfool commented May 20, 2020

Running dotnet-outdated after changes:

Cake/src on  gh2778 via •NET v3.1.300
❯ dotnet outdated
» Cake
  [.NETCoreApp,Version=v3.0]
  Autofac  4.9.4 -> 5.2.0
  [.NETCoreApp,Version=v2.0]
  Autofac  4.9.4 -> 5.2.0
  [.NETFramework,Version=v4.6.1]
  Autofac  4.9.4 -> 5.2.0
  [.NETCoreApp,Version=v2.1]
  Autofac  4.9.4 -> 5.2.0

Version color legend:
<red>   : Major version update or pre-release version. Possible breaking changes.
<yellow>: Minor version update. Backwards-compatible features added.
<green> : Patch version update. Backwards-compatible bug fixes.

You can upgrade packages to the latest version by passing the -u or -u:prompt option.
Elapsed: 00:00:06.2767355

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot going on in this one.

Could you start with the style cop upgrade and fixes in a separate issue and PR?

@gitfool
Copy link
Contributor Author

gitfool commented May 20, 2020

Sure. I'll suppress the StyleCop warnings in the first commit of this PR.

@devlead
Copy link
Member

devlead commented May 20, 2020

@gitfool we

Sure. I'll suppress the StyleCop warnings in the first commit of this PR.

As we use issues for release notes and changelog, we would prefer dependency bump to be a bit more focused, so not about suppressing issues, but just have the work for style copy dependency upgrade and fixes in a separate issue and PR.

@gitfool
Copy link
Contributor Author

gitfool commented May 20, 2020

Understood. I'll keep StyleCop.Analyzers at 1.1.0-beta004 for this PR.

@devlead devlead added this to the v1.0.0 milestone Jun 29, 2020
@devlead devlead merged commit 2d9db7c into cake-build:develop Jun 29, 2020
@devlead
Copy link
Member

devlead commented Jun 29, 2020

@gitfool your changes have been merged, thanks for your contribution 👍

@gep13
Copy link
Member

gep13 commented Jun 29, 2020

@devlead the issue associated with this PR is marked as having been fixed in 0.38.0. Does that need to be updated?

@devlead
Copy link
Member

devlead commented Jun 29, 2020

I will add a new issue, linked issue is for roslyn and already shipped.

@devlead devlead changed the title GH2778: Bump dependencies GH2817: Bump dependencies Jun 29, 2020
@devlead devlead removed this from the v1.0.0 milestone Jun 29, 2020
@devlead devlead linked an issue Jun 29, 2020 that may be closed by this pull request
@devlead devlead mentioned this pull request Jun 29, 2020
@gitfool gitfool deleted the gh2778 branch June 29, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump dependencies Update Roslyn to 3.6.0
3 participants