Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsoleted XmlPoke Aliases #978

Closed
devlead opened this issue Jun 10, 2016 · 8 comments
Closed

Remove obsoleted XmlPoke Aliases #978

devlead opened this issue Jun 10, 2016 · 8 comments
Assignees
Milestone

Comments

@devlead
Copy link
Member

devlead commented Jun 10, 2016

As discussed in #974 it's now time to remove the obsoleted XmlPoke aliases.

@devlead devlead added this to the v0.14.0 milestone Jun 10, 2016
@devlead devlead self-assigned this Jun 10, 2016
devlead added a commit to devlead/cake that referenced this issue Jun 10, 2016
devlead added a commit to devlead/cake that referenced this issue Jun 10, 2016
@gep13
Copy link
Member

gep13 commented Jun 10, 2016

@devlead If you want the Breaking Change label to appear in the release notes, which i think is a good idea, we will need to add the label to the GitReleaseManager.yaml file, so that it picks it up.

@devlead
Copy link
Member Author

devlead commented Jun 10, 2016

@gep13 agree, should I send a separate pr/issue there?

@gep13
Copy link
Member

gep13 commented Jun 10, 2016

@devlead yes, I think that would be justified, yes.

@devlead
Copy link
Member Author

devlead commented Jun 10, 2016

@gep13 cool, I'll fix that shortly.

@devlead
Copy link
Member Author

devlead commented Jun 10, 2016

@gep13 #979 should be ready for review as is then.

gep13 added a commit that referenced this issue Jun 10, 2016
Removed obsoleted XmlPoke aliases
@gep13
Copy link
Member

gep13 commented Jun 10, 2016

@devlead I think it was mentioned elsewhere as well, but just to recap... I think we need a new page on the website that lists when Aliases were obsoleted, i.e. in what version of Cake. And we can keep a track of things there, so that we can point people to.

i.e. when method was added, when it was obsoleted, and when it was removed.

Thoughts?

@patriksvensson
Copy link
Member

@gep13 @devlead Yes, I think this is a good idea. Actually, we could create our own ObsoleteAttribute as well with this information and generate it from the NuGet package.

@devlead
Copy link
Member Author

devlead commented Jun 10, 2016

We could use something like Particular Software API comparer to diff public APIs between versions.

@gep13 gep13 changed the title Remove obsoleted XmlPoke aliases Remove obsoleted XmlPoke Aliases Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants