Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger notifications (twitter, gitter, etc.) upon successful nuget task, not just on successful build #299

Closed
MihaMarkic opened this issue Dec 11, 2018 · 0 comments · Fixed by #541
Closed

Trigger notifications (twitter, gitter, etc.) upon successful nuget task, not just on successful build #299

MihaMarkic opened this issue Dec 11, 2018 · 0 comments · Fixed by #541
Labels
Improvement
Milestone
2.0.0

Comments

@MihaMarkic
Copy link

Currently the notifications won't be triggered if nuget push succeeds but build later fails somewhere.
Which is a bit inconsistent.
IMO it would be better handled if notifications were triggered on nuget task success regardless of the final outcome.
@gep13 gep13 added this to the 2.0.0 milestone Sep 9, 2019
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 9, 2020
@gep13
(cake-contribGH-299) Change how notifications are sent
59cbb05 
Previously, a build had to be completely successful before notifications
were sent to Twitter/Gitter, etc.  However, it is possible to some
publishing tasks fail, but the artifacts are still sent to their end
location, i.e NuGet.org.  In these cases, it would make sense for the
notifications to be sent, since the packages have been released.  As
such, the Teardown method has been updated to send notifications, when
it knows artifacts have been sent successfully.
@gep13 gep13 mentioned this issue Jul 9, 2020
Merged
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 9, 2020
@gep13
(cake-contribGH-299) Change how notifications are sent
87eff84 
Previously, a build had to be completely successful before notifications
were sent to Twitter/Gitter, etc.  However, it is possible to some
publishing tasks fail, but the artifacts are still sent to their end
location, i.e NuGet.org.  In these cases, it would make sense for the
notifications to be sent, since the packages have been released.  As
such, the Teardown method has been updated to send notifications, when
it knows artifacts have been sent successfully.
AdmiringWorm added a commit that referenced this issue Jul 9, 2020
@AdmiringWorm
Merge pull request #541 from gep13/feature/GH-299
85ee639 
(GH-299) Change how notifications are sent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-299) Change how notifications are sent gep13/Cake.Recipe
3 participants
@gep13 @AdmiringWorm @MihaMarkic