(GH-299) Change how notifications are sent #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a build had to be completely successful before notifications were sent to Twitter/Gitter, etc. However, it is possible to some publishing tasks fail, but the artifacts are still sent to their end location, i.e NuGet.org. In these cases, it would make sense for the notifications to be sent, since the packages have been released. As such, the Teardown method has been updated to send notifications, when it knows artifacts have been sent successfully.
AdmiringWorm
reviewed
Jul 9, 2020
|
@gep13 your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a build had to be completely successful before notifications
were sent to Twitter/Gitter, etc. However, it is possible to some
publishing tasks fail, but the artifacts are still sent to their end
location, i.e NuGet.org. In these cases, it would make sense for the
notifications to be sent, since the packages have been released. As
such, the Teardown method has been updated to send notifications, when
it knows artifacts have been sent successfully.
Fixes #299